[edk2-devel] [edk2-platforms][PATCH v1 0/5] MinPlatformPkg: TestPointCheckLib bug fixes and improvements

[Michael Kubacki]

Thanks for the feedback, I addressed it in a v2 series:
   https://edk2.groups.io/g/devel/message/78767

Regards,
Michael

On 8/5/2021 7:14 PM, Nate DeSimone wrote:
> Hi Michael,
> 
> Here is a summary of my feedback:
> 
>    1. Patch 2/5: DxeCheckTcgTrustedBoot.c: line 44 - I think we should also have a ZeroMem ((VOID *) &ProtocolCapability, sizeof (ProtocolCapability)) before setting the size.
>    2. Patch 3/5: SmmTestPointCheckLib.c: line 112 - I think we should have a #define that describes whatever "6" means in this context.
> 
> Everything else looks good!
> 
> Thanks,
> Nate
> 
>> -----Original Message-----
>> From: devel at edk2.groups.io <devel at edk2.groups.io> On Behalf Of Michael
>> Kubacki
>> Sent: Thursday, August 5, 2021 7:57 AM
>> To: devel at edk2.groups.io
>> Cc: Chiu, Chasel <chasel.chiu at intel.com>; Desimone, Nathaniel L
>> <nathaniel.l.desimone at intel.com>; Liming Gao
>> <gaoliming at byosoft.com.cn>; Dong, Eric <eric.dong at intel.com>
>> Subject: [edk2-devel] [edk2-platforms][PATCH v1 0/5] MinPlatformPkg:
>> TestPointCheckLib bug fixes and improvements
>>
>> From: Michael Kubacki <mailto:michael.kubacki at microsoft.com>
>>
>> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3531
>> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3518
>> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3520
>> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3521
>>
>> This patch series groups together several bug fixes and improvements to
>> TestPointCheckLib. The first patch is required for the others since it fixes a
>> MinPlatformPkg build issue that occurs with the current edk2/master branch.
>>
>> Cc: Chasel Chiu <mailto:chasel.chiu at intel.com>
>> Cc: Nate DeSimone <mailto:nathaniel.l.desimone at intel.com>
>> Cc: Liming Gao <mailto:gaoliming at byosoft.com.cn>
>> Cc: Eric Dong <mailto:eric.dong at intel.com>
>> Signed-off-by: Michael Kubacki <mailto:michael.kubacki at microsoft.com>
>>
>> Michael Kubacki (5):
>>    MinPlatformPkg/TestPointCheckLib: Fix MessageLength cast issue
>>    MinPlatformPkg/TestPointCheckLib: Set required size field in protocol
>>    MinPlatformPkg/TestPointCheckLib: Fix incorrect array index
>>    MinPlatformPkg/TestPointCheckLib: Improve adjacent region checking
>>    MinPlatformPkg/TestPointCheckLib: Make OutTable parameter optional
>>
>>
>> Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckA
>> cpi.c                 | 32 +++++------
>>
>> Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckS
>> miHandlerInstrument.c |  4 +-
>>
>> Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckS
>> mmInfo.c              | 56 ++++++++++----------
>>
>> Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckTc
>> gTrustedBoot.c       |  1 +
>>
>> Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeTestPoi
>> ntCheckLib.c         | 15 +++++-
>>
>> Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/SmmTestPo
>> intCheckLib.c         |  4 +-
>>   Platform/Intel/MinPlatformPkg/Test/TestPointStubDxe/TestPointStubDxe.c
>> | 10 ++--
>>
>> Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeTestPoi
>> ntCheckLib.inf       |  1 +
>>   8 files changed, 70 insertions(+), 53 deletions(-)
>>
>> --
>> 2.28.0.windows.1
>>
>>
>>
>> -=-=-=-=-=-=
>> Groups.io Links: You receive all messages sent to this group.
>> View/Reply Online (#78710): https://edk2.groups.io/g/devel/message/78710
>> Mute This Topic: https://groups.io/mt/84686301/1767664
>> Group Owner: mailto:devel+owner at edk2.groups.io
>> Unsubscribe: https://edk2.groups.io/g/devel/unsub
>> [nathaniel.l.desimone at intel.com]
>> -=-=-=-=-=-=
>>
> 
> 
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#78773): https://edk2.groups.io/g/devel/message/78773
Mute This Topic: https://groups.io/mt/84686301/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-