[edk2-devel] [PATCH v2] UefiCpuPkg/CpuCacheInfoLib: Sort CpuCacheInfo array
Ni, Ray
ray.ni at intel.com
Fri Aug 6 14:01:03 UTC 2021
With the renaming, Reviewed-by: Ray Ni <ray.ni at intel.com>
> -----Original Message-----
> From: Ni, Ray
> Sent: Friday, August 6, 2021 9:55 PM
> To: Lou, Yun <Yun.Lou at intel.com>; devel at edk2.groups.io
> Cc: Dong, Eric <eric.dong at intel.com>; Laszlo Ersek <lersek at redhat.com>; Kumar, Rahul1 <Rahul1.Kumar at intel.com>
> Subject: RE: [PATCH v2] UefiCpuPkg/CpuCacheInfoLib: Sort CpuCacheInfo array
>
> The patch looks good to me. 2 minor comments:
> > + } Fields;
> 1. Can you rename to "Bits" to align to existing naming convention?
>
> >
> > + UINT64 Data64;
>
> 2. Can you rename to "Uint64"?
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#78807): https://edk2.groups.io/g/devel/message/78807
Mute This Topic: https://groups.io/mt/84704801/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-
More information about the edk2-devel-archive
mailing list