[edk2-devel] [edk2-platforms][PATCH v1 1/4] KabylakeOpenBoardPkg/Acpi: BoardAcpiDxe also installs all PcdAcpiTableStorageFile
Nate DeSimone
nathaniel.l.desimone at intel.com
Fri Aug 13 07:03:53 UTC 2021
Hi Benjamin,
It would be good to add a check on the status code returned from PublishAcpiTablesFromFv() to the debug log. Something like this:
Status = PublishAcpiTablesFromFv (&gEfiCallerIdGuid);
if (EFI_ERROR (Status)) {
DEBUG ((DEBUG_ERROR, "Error: PublishAcpiTablesFromFv[%g] - %r", &gEfiCallerIdGuid, Status));
}
Status = PublishAcpiTablesFromFv (PcdGetPtr (PcdAcpiTableStorageFile));
if (EFI_ERROR (Status)) {
DEBUG ((
DEBUG_ERROR,
"Error: PublishAcpiTablesFromFv[%g] - %r",
PcdGetPtr (PcdAcpiTableStorageFile),
Status
));
}
I know the original code doesn't do it, but I imagine this will be helpful to some poor soul who is trying to debug issues with this later on.
Thanks,
Nate
-----Original Message-----
From: Benjamin Doron <benjamin.doron00 at gmail.com>
Sent: Wednesday, August 4, 2021 12:59 PM
To: devel at edk2.groups.io
Cc: Chiu, Chasel <chasel.chiu at intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone at intel.com>
Subject: [edk2-platforms][PATCH v1 1/4] KabylakeOpenBoardPkg/Acpi: BoardAcpiDxe also installs all PcdAcpiTableStorageFile
Follow AcpiPlatformDxe (from which this module is derived) and install all ACPI tables added by board.
Cc: Chasel Chiu <chasel.chiu at intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone at intel.com>
Signed-off-by: Benjamin Doron <benjamin.doron00 at gmail.com>
---
Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.c | 1 +
Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.inf | 2 ++
2 files changed, 3 insertions(+)
diff --git a/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.c b/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.c
index 0361ffc2fbf9..fd227d9b410e 100644
--- a/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.c
+++ b/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe
+++ .c
@@ -289,6 +289,7 @@ InstallAcpiBoard (
// Platform ACPI Tables // PublishAcpiTablesFromFv (&gEfiCallerIdGuid);+ PublishAcpiTablesFromFv (PcdGetPtr (PcdAcpiTableStorageFile)); // // This protocol publish must be done after PublishAcpiTablesFromFv.diff --git a/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.inf b/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.inf
index 7d2e105e5447..4d7f5cdb3eeb 100644
--- a/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.inf
+++ b/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe
+++ .inf
@@ -59,6 +59,8 @@
gKabylakeOpenBoardPkgTokenSpaceGuid.PcdDisablePassiveTripPoints gKabylakeOpenBoardPkgTokenSpaceGuid.PcdDisableCriticalTripPoints + gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiTableStorageFile+ [Depex] gEfiAcpiTableProtocolGuid AND gEfiFirmwareVolume2ProtocolGuid AND--
2.31.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#79257): https://edk2.groups.io/g/devel/message/79257
Mute This Topic: https://groups.io/mt/84670593/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-
More information about the edk2-devel-archive
mailing list