[edk2-devel] [PATCH 1/1] MdeModulePkg/CapsuleApp: Add missing EFIAPI specifier

Marvin Häuser mhaeuser at posteo.de
Sun Aug 15 20:11:55 UTC 2021


The function CompareFileNameInAlphabet() is passed by pointer to a
generic sorting function. Said pointer declares a function type with
the EFIAPI calling convention. As CompareFileNameInAlphabet() lacks
said specifier, this causes build issues with toolchains that do not
use the EFIAPI calling convention by default, such as CLANG38.

Add the missing specifier to resolve the issue.

Cc: Jian J Wang <jian.j.wang at intel.com>
Cc: Hao A Wu <hao.a.wu at intel.com>
Cc: Liming Gao <gaoliming at byosoft.com.cn>
Cc: Guomin Jiang <guomin.jiang at intel.com>
Cc: Vitaly Cheptsov <vit9696 at protonmail.com>
Signed-off-by: Marvin Häuser <mhaeuser at posteo.de>
---
 MdeModulePkg/Application/CapsuleApp/CapsuleDump.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MdeModulePkg/Application/CapsuleApp/CapsuleDump.c b/MdeModulePkg/Application/CapsuleApp/CapsuleDump.c
index 5725e2f6dd5b..30a4a984f318 100644
--- a/MdeModulePkg/Application/CapsuleApp/CapsuleDump.c
+++ b/MdeModulePkg/Application/CapsuleApp/CapsuleDump.c
@@ -622,6 +622,7 @@ SplitFileNameExtension (
 

 **/

 INTN

+EFIAPI

 CompareFileNameInAlphabet (

   IN VOID                         *Left,

   IN VOID                         *Right

-- 
2.31.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#79315): https://edk2.groups.io/g/devel/message/79315
Mute This Topic: https://groups.io/mt/84909445/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-






More information about the edk2-devel-archive mailing list