[edk2-devel] [edk2-platforms][PATCH v2 0/5] KabylakeOpenBoardPkg: Add AspireVn7Dash572G
Nate DeSimone
nathaniel.l.desimone at intel.com
Mon Aug 16 05:31:17 UTC 2021
Sorry 2 more general comments:
1. Please add the Acer Aspire VN-572G to the list of supported platforms in Platform/Intel/Readme.md
2. If you like you are welcome to add Copyright (c) 2021, Benjamin Doran to the files that you modified. You don't work for any company so you're work on this project belongs to you. Of course, you have to be willing to extend a BSD+Patent license to upstream your work to TianoCore but you already have done this :).
> -----Original Message-----
> From: devel at edk2.groups.io <devel at edk2.groups.io> On Behalf Of Nate
> DeSimone
> Sent: Sunday, August 15, 2021 10:22 PM
> To: devel at edk2.groups.io; benjamin.doron00 at gmail.com
> Subject: Re: [edk2-devel] [edk2-platforms][PATCH v2 0/5]
> KabylakeOpenBoardPkg: Add AspireVn7Dash572G
>
> Hi Benjamin,
>
> First of all this is fantastic work, it is very clear that you have put a lot of effort
> into this. Thank you for doing so! I do have some minor code review
> comments for you. Here is a summary of my feedback:
>
> 1.
> KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Library/PeiSilicon
> PolicyUpdateLibFsp/PcieDeviceTable.c: Line 16:
>
> I think it would be a good idea to file a Bugzilla for this. Could you please do
> so?
>
> 2.
> KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Library/PeiSilicon
> PolicyUpdateLibFsp/PeiBoardPolicyUpdate.c
>
> A lot of this code in this file demonstrates that is probably makes sense to
> create a top level PolicyUpdateLib in KabylakeOpenBoardPkg that the various
> board ports import because most of these settings look either identical to
> RVP3/GalagoPro3 or they come from PCDs and hence the code will always be
> generic.
>
> Definitely not something you need to do for this patch series, but something
> to think about for a future enhancement.
>
> 2(a). Line 49:
>
> I find the whole situation with PchHpetBusNumber,
> PchHpetBusDeviceNumber, PchHpetFunctionNumber, PchHpetBdfValid to
> be very odd.
>
> I looked though the FSP source code to see what these policy options do
> and it boils down to if(PchHpetBdfValid) then the FSP will program the
> following register:
>
> https://edc.intel.com/content/www/us/en/design/products-and-
> solutions/processors-and-chipsets/comet-lake-u/intel-400-series-chipset-
> on-package-platform-controller-hub-register-database/hpet-bus-device-
> function-hbdf-offset-70/
>
> I can confirm that in the FSP source code that the default FSP UPD values
> differ from the default config block values. Moreover, the reference BIOS
> takes the config blocks and converts them into FSP UPDs just like the open
> source code, so most of the testing for KBL FSP was actually done without
> the default UPD values. We consider cases like this where the UPD and the
> config block defaults don't match to be a bug, but given the age of the KBL
> FSP getting that bug fixed is difficult at this point.
>
> Have you tried booting these settings?
> PchHpetBdfValid = 0
> PchHpetBusNumber = 0
> PchHpetBusDeviceNumber = 0
> PchHpetFunctionNumber = 0
>
> That is what the reference BIOS uses.
>
> The equivalent UPD and Config Block defaults for I/O APIC do match.
>
> 2(b). Line 50:
> The default for PeciC10Reset should totally be 1. Good catch!
>
> I have created a patch to fix the properly. Please merge
> https://edk2.groups.io/g/devel/message/79328
>
> Then we should be able to remove this line.
>
> 2(c). Line 97:
> This is OK for your initial patch series but please make sure work on a follow
> up patch series that moves this to a setup option since it is insecure to have
> this be the default.
>
> 2(d). Line 107:
> From what I remember the VN-572G only supports S3 and not S0ix. In
> which case setting PchPmSlpS0VmEnable = 0 would be mandatory because
> that feature only works in S0ix mode. Historically most systems with
> switchable graphics have opted for S3 instead of S0ix because power state
> transitions are more difficult to implement correctly in S0ix.
>
> Please add a comment that describes this.
>
> 2(e). Line 198:
> Please create a #define for "3" that describes why these settings are
> significant for only the first 3 USB2 ports.
>
> Also, using a variable called "i" as the index variable of a for loop does not
> comply with EDK II coding style guidelines, please use "Index" instead.
>
> 2(f) Line 205:
> Please create a #define for "9" that describes why these settings are
> significant for USB2 ports 3-9.
>
> Also, using a variable called "i" as the index variable of a for loop does not
> comply with EDK II coding style guidelines, please use "Index" instead.
>
> 2(g) Line 212:
> Please create a #define for the number of populated USB3 ports.
>
> Also, using a variable called "i" as the index variable of a for loop does not
> comply with EDK II coding style guidelines, please use "Index" instead.
>
> 2(h). Line 219:
> Please use PCH_LP_XHCI_MAX_USB2_PORTS instead of 12.
>
> Also, using a variable called "i" as the index variable of a for loop does not
> comply with EDK II coding style guidelines, please use "Index" instead.
>
> 2(i). Line 222:
> Please use PCH_LP_XHCI_MAX_USB3_PORTS instead of 6.
>
> Also, using a variable called "i" as the index variable of a for loop does not
> comply with EDK II coding style guidelines, please use "Index" instead.
>
> 3. KabylakeOpenBoardPkg/AspireVn7Dash572G/Include/EcCommands.h:
> Line 45:
> We have this in the original code for triggering some board-specific
> workarounds needed on old/early builds of RVP3 but not later ones.
>
> Given that the AspireVn7Dash572G is now disconnected from the
> KabylakeRvp3, would it be possible to remove the command to EC for
> reading the Fab Id? That scenario seems non applicable to the VN-572G.
>
> 4.
> KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib/PeiAspire
> Vn7Dash572GInitPostMemLib.c
>
> 4(a). Line 56:
> Please add a header comment that describes what this function does.
>
> 4(b). Line 58:
> Function name doesn't follow EDK II coding style guidelines. Please rename
> to EcFillsTime().
>
> 4(c). Line 81:
> Please don't commit commented out/#if 0 code.
>
> 4(d). Line 119:
> Please delete trailing whitespace
>
> 5. KabylakeOpenBoardPkg/AspireVn7Dash572G/OpenBoardPkgPcd.dsc: Line
> 188:
> PcdSiCsmEnable is just tells the SiPkg that the platform code contains a
> CSM. It is one of many... many things you would need to do for proper CSM
> support in KabylakeOpenBoardPkg and is way beyond the scope of this GSoC
> project :)
>
> Everything else looks good!
>
> Thanks,
> Nate
>
> > -----Original Message-----
> > From: devel at edk2.groups.io <devel at edk2.groups.io> On Behalf Of
> > Benjamin Doron
> > Sent: Friday, August 13, 2021 5:25 PM
> > To: devel at edk2.groups.io
> > Subject: [edk2-devel] [edk2-platforms][PATCH v2 0/5]
> > KabylakeOpenBoardPkg: Add AspireVn7Dash572G
> >
> > This patchset adds support for a Acer Aspire VN7-572G (SKL-U laptop)
> > board to KabylakeOpenBoardPkg, based on Kabylake RVP 3. As stated in a
> > later commit message, there is a second, similar board: VN7-792G.
> > - VN7-572G = "Rayleigh". Working, supported. Uses PCH-LP.
> > - VN7-792G = "Newgate". Assumed broken, not supported. Uses PCH-H.
> > Also known as the "Black Edition" of the Aspire V Nitro.
> >
> > Because VN7-792G uses a different PCH, routing and GPIO configuration
> > are assumed to be different. Users are strongly warned against
> > attempting to flash images to VN7-792G at this time. Support may be
> > added later by reverse engineering, but logs from a running system will
> help.
> >
> > Additional build depedencies:
> > - https://github.com/benjamindoron/edk2-non-
> > osi/commit/7bf736989159b74012d9bf3a13a9f941036be97a
> > -
> >
> https://github.com/benjamindoron/edk2/commit/db888a928c1c6fc94f6a767
> > 0f3402718c10c01d2
> >
> > V2 changes:
> > - Whitespace changes and changes for coding guidelines compliance
> > - KabylakeOpenBoardPkg changes merged into "duplicate KabylakeRvp3"
> > commit
> > - EC (ACPI): LGMR hooked-up (disabled), other changes.
> > - FSP-S configuration: Drop thermal changes not set by board, do not
> > override UART2 mode (PCI by policy)
> > - Set DspEndpointDmic so FSP produces correct configuration in HOB for
> > PchInitDxe. (However, 1ch array DMIC may not be supported by the
> > Linux driver. Also, presently NHLT is not installed in any case:
> > DspEnable=0 in HOB.)
> > - Avoid indirect function calls for GPIO configuration and deduplicate
> > HSIO tables
> > - Make board detection work and parse PCB version information
> > - Begin working on hardening platform and improving PCD
> > - DXE stack guard, NX for stack, NULL pointer detection (DXE NX is
> > broken)
> > - Measure FSP to TPM (presently skipping FSP-S, there may be a bug
> > where the first TPM command from this time will timeout waiting for
> > goIdle)
> > - UGA draw protocol and HII OS runtime disabled, fast PS/2 detection
> >
> > Benjamin Doron (5):
> > KabylakeOpenBoardPkg/BaseEcLib: Add some common EC commands
> > KabylakeOpenBoardPkg/AspireVn7Dash572G: Duplicate KabylakeRvp3
> > directory
> > KabylakeOpenBoardPkg/AspireVn7Dash572G: Rename KabylakeRvp3 files
> > Platform/Intel: Early hook-up Acer Aspire VN7-572G
> > KabylakeOpenBoardPkg/AspireVn7Dash572G: Add initial support
> >
> >
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Acpi/BoardAcpi
> > Tables.inf | 18 +
> >
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Acpi/BoardSsdt
> > .asl | 34 +
> > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Acpi/ac.asl
> > | 16 +
> >
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Acpi/battery.as
> > l | 408 +++++++++++
> > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Acpi/ec.asl
> > | 431 ++++++++++++
> >
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Acpi/mainboar
> > d.asl | 79 +++
> >
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Acpi/thermal.a
> > sl | 117 ++++
> >
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Li
> > brary/PeiSiliconPolicyUpdateLibFsp/PcieDeviceTable.c | 104 +++
> >
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Li
> > brary/PeiSiliconPolicyUpdateLibFsp/PeiBoardPolicyUpdate.c | 288
> > ++++++++
> >
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Li
> > brary/PeiSiliconPolicyUpdateLibFsp/PeiFspMiscUpdUpdateLib.c | 82
> +++
> >
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Li
> > brary/PeiSiliconPolicyUpdateLibFsp/PeiFspPolicyUpdateLib.c | 213
> > ++++++
> >
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Li
> > brary/PeiSiliconPolicyUpdateLibFsp/PeiPchPolicyUpdate.c | 139 ++++
> >
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Li
> > brary/PeiSiliconPolicyUpdateLibFsp/PeiPchPolicyUpdate.h | 26 +
> >
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Li
> > brary/PeiSiliconPolicyUpdateLibFsp/PeiPchPolicyUpdatePreMem.c | 243
> > +++++++
> >
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Li
> > brary/PeiSiliconPolicyUpdateLibFsp/PeiSaPolicyUpdate.c | 77 ++
> >
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Li
> > brary/PeiSiliconPolicyUpdateLibFsp/PeiSaPolicyUpdate.h | 29 +
> >
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Li
> > brary/PeiSiliconPolicyUpdateLibFsp/PeiSaPolicyUpdatePreMem.c | 66
> ++
> >
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Li
> > brary/PeiSiliconPolicyUpdateLibFsp/PeiSiliconPolicyUpdateLibFsp.inf |
> > 145
> > ++++
> > Platform/Intel/KabylakeOpenBoardPkg/{KabylakeRvp3 =>
> > AspireVn7Dash572G}/Include/EcCommands.h | 7 +-
> >
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Include/Fdf/Fla
> > shMapInclude.fdf | 50 ++
> >
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Include/Library
> > /BoardEcLib.h | 112 +++
> >
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardA
> > cpiLib/DxeAspireVn7Dash572GAcpiTableLib.c | 74 ++
> >
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardA
> > cpiLib/DxeBoardAcpiTableLib.c | 30 +
> >
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardA
> > cpiLib/DxeBoardAcpiTableLib.inf | 47 ++
> >
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardA
> > cpiLib/SmmAspireVn7Dash572GAcpiEnableLib.c | 64 ++
> >
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardA
> > cpiLib/SmmBoardAcpiEnableLib.c | 55 ++
> >
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardA
> > cpiLib/SmmBoardAcpiEnableLib.inf | 45 ++
> >
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardA
> > cpiLib/SmmSiliconAcpiEnableLib.c | 166 +++++
> > Platform/Intel/KabylakeOpenBoardPkg/{Library/BaseEcLib/BaseEcLib.inf
> =>
> > AspireVn7Dash572G/Library/BoardEcLib/BoardEcLib.inf} | 13 +-
> >
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardE
> > cLib/EcCommands.c | 218 ++++++
> >
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardI
> > nitLib/AspireVn7Dash572GGpioTable.c | 398 +++++++++++
> >
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardI
> > nitLib/AspireVn7Dash572GHdaVerbTables.c | 203 ++++++
> >
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardI
> > nitLib/AspireVn7Dash572GHsioPtssTables.c | 26 +
> >
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardI
> > nitLib/PeiAspireVn7Dash572GDetect.c | 97 +++
> >
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardI
> > nitLib/PeiAspireVn7Dash572GInitLib.h | 33 +
> >
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardI
> > nitLib/PeiAspireVn7Dash572GInitPostMemLib.c | 126 ++++
> >
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardI
> > nitLib/PeiAspireVn7Dash572GInitPreMemLib.c | 344
> +++++++++
> >
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardI
> > nitLib/PeiBoardInitPostMemLib.c | 34 +
> >
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardI
> > nitLib/PeiBoardInitPostMemLib.inf | 47 ++
> >
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardI
> > nitLib/PeiBoardInitPreMemLib.c | 99 +++
> >
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardI
> > nitLib/PeiBoardInitPreMemLib.inf | 126 ++++
> >
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/OpenBoardPkg
> > .dsc | 674 ++++++++++++++++++
> >
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/OpenBoardPkg
> > .fdf | 733 ++++++++++++++++++++
> >
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/OpenBoardPkg
> > BuildOption.dsc | 153 ++++
> >
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/OpenBoardPkg
> > Pcd.dsc | 546 +++++++++++++++
> >
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/
> > DxeSiliconPolicyUpdateLib/DxeGopPolicyInit.c | 188 +++++
> >
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/
> > DxeSiliconPolicyUpdateLib/DxeGopPolicyInit.h | 39 ++
> >
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/
> > DxeSiliconPolicyUpdateLib/DxeSaPolicyInit.h | 64 ++
> >
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/
> > DxeSiliconPolicyUpdateLib/DxeSaPolicyUpdate.c | 63 ++
> >
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/
> > DxeSiliconPolicyUpdateLib/DxeSiliconPolicyUpdateLib.c | 74 ++
> >
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/
> > DxeSiliconPolicyUpdateLib/DxeSiliconPolicyUpdateLib.inf | 52 ++
> >
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/
> > PeiSiliconPolicyUpdateLib/PeiBoardPolicyUpdate.c | 332
> +++++++++
> >
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/
> > PeiSiliconPolicyUpdateLib/PeiSiliconPolicyUpdateLib.c | 642
> > +++++++++++++++++
> >
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/
> > PeiSiliconPolicyUpdateLib/PeiSiliconPolicyUpdateLib.inf | 107 +++
> >
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/build_config.cf
> > g | 35 +
> > Platform/Intel/KabylakeOpenBoardPkg/Include/Library/EcLib.h
> > | 32 +
> > Platform/Intel/KabylakeOpenBoardPkg/Include/PlatformBoardId.h
> > | 2 +
> >
> >
> Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Include/EcCommands
> > .h | 2 +
> > Platform/Intel/KabylakeOpenBoardPkg/Library/BaseEcLib/BaseEcLib.c
> > | 4 +-
> > Platform/Intel/KabylakeOpenBoardPkg/Library/BaseEcLib/BaseEcLib.inf
> > | 1 +
> > Platform/Intel/KabylakeOpenBoardPkg/Library/BaseEcLib/EcCommands.c
> > | 76 ++
> > Platform/Intel/KabylakeOpenBoardPkg/OpenBoardPkg.dec
> > | 1 +
> > Platform/Intel/build.cfg
> > | 1 +
> > 63 files changed, 8741 insertions(+), 9 deletions(-) create mode
> > 100644
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Acpi/BoardAcpi
> > Tables.inf
> > create mode 100644
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Acpi/BoardSsdt
> > .asl
> > create mode 100644
> > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Acpi/ac.asl
> > create mode 100644
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Acpi/battery.as
> > l
> > create mode 100644
> > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Acpi/ec.asl
> > create mode 100644
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Acpi/mainboar
> > d.asl
> > create mode 100644
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Acpi/thermal.a
> > sl
> > create mode 100644
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Li
> > brary/PeiSiliconPolicyUpdateLibFsp/PcieDeviceTable.c
> > create mode 100644
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Li
> > brary/PeiSiliconPolicyUpdateLibFsp/PeiBoardPolicyUpdate.c
> > create mode 100644
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Li
> > brary/PeiSiliconPolicyUpdateLibFsp/PeiFspMiscUpdUpdateLib.c
> > create mode 100644
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Li
> > brary/PeiSiliconPolicyUpdateLibFsp/PeiFspPolicyUpdateLib.c
> > create mode 100644
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Li
> > brary/PeiSiliconPolicyUpdateLibFsp/PeiPchPolicyUpdate.c
> > create mode 100644
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Li
> > brary/PeiSiliconPolicyUpdateLibFsp/PeiPchPolicyUpdate.h
> > create mode 100644
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Li
> > brary/PeiSiliconPolicyUpdateLibFsp/PeiPchPolicyUpdatePreMem.c
> > create mode 100644
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Li
> > brary/PeiSiliconPolicyUpdateLibFsp/PeiSaPolicyUpdate.c
> > create mode 100644
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Li
> > brary/PeiSiliconPolicyUpdateLibFsp/PeiSaPolicyUpdate.h
> > create mode 100644
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Li
> > brary/PeiSiliconPolicyUpdateLibFsp/PeiSaPolicyUpdatePreMem.c
> > create mode 100644
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Li
> > brary/PeiSiliconPolicyUpdateLibFsp/PeiSiliconPolicyUpdateLibFsp.inf
> > copy Platform/Intel/KabylakeOpenBoardPkg/{KabylakeRvp3 =>
> > AspireVn7Dash572G}/Include/EcCommands.h (74%) create mode 100644
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Include/Fdf/Fla
> > shMapInclude.fdf
> > create mode 100644
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Include/Library
> > /BoardEcLib.h
> > create mode 100644
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardA
> > cpiLib/DxeAspireVn7Dash572GAcpiTableLib.c
> > create mode 100644
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardA
> > cpiLib/DxeBoardAcpiTableLib.c
> > create mode 100644
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardA
> > cpiLib/DxeBoardAcpiTableLib.inf
> > create mode 100644
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardA
> > cpiLib/SmmAspireVn7Dash572GAcpiEnableLib.c
> > create mode 100644
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardA
> > cpiLib/SmmBoardAcpiEnableLib.c
> > create mode 100644
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardA
> > cpiLib/SmmBoardAcpiEnableLib.inf
> > create mode 100644
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardA
> > cpiLib/SmmSiliconAcpiEnableLib.c
> > copy
> > Platform/Intel/KabylakeOpenBoardPkg/{Library/BaseEcLib/BaseEcLib.inf
> > => AspireVn7Dash572G/Library/BoardEcLib/BoardEcLib.inf} (58%) create
> > mode
> > 100644
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardE
> > cLib/EcCommands.c
> > create mode 100644
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardI
> > nitLib/AspireVn7Dash572GGpioTable.c
> > create mode 100644
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardI
> > nitLib/AspireVn7Dash572GHdaVerbTables.c
> > create mode 100644
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardI
> > nitLib/AspireVn7Dash572GHsioPtssTables.c
> > create mode 100644
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardI
> > nitLib/PeiAspireVn7Dash572GDetect.c
> > create mode 100644
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardI
> > nitLib/PeiAspireVn7Dash572GInitLib.h
> > create mode 100644
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardI
> > nitLib/PeiAspireVn7Dash572GInitPostMemLib.c
> > create mode 100644
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardI
> > nitLib/PeiAspireVn7Dash572GInitPreMemLib.c
> > create mode 100644
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardI
> > nitLib/PeiBoardInitPostMemLib.c
> > create mode 100644
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardI
> > nitLib/PeiBoardInitPostMemLib.inf
> > create mode 100644
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardI
> > nitLib/PeiBoardInitPreMemLib.c
> > create mode 100644
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardI
> > nitLib/PeiBoardInitPreMemLib.inf
> > create mode 100644
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/OpenBoardPkg
> > .dsc
> > create mode 100644
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/OpenBoardPkg
> > .fdf
> > create mode 100644
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/OpenBoardPkg
> > BuildOption.dsc
> > create mode 100644
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/OpenBoardPkg
> > Pcd.dsc
> > create mode 100644
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/
> > DxeSiliconPolicyUpdateLib/DxeGopPolicyInit.c
> > create mode 100644
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/
> > DxeSiliconPolicyUpdateLib/DxeGopPolicyInit.h
> > create mode 100644
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/
> > DxeSiliconPolicyUpdateLib/DxeSaPolicyInit.h
> > create mode 100644
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/
> > DxeSiliconPolicyUpdateLib/DxeSaPolicyUpdate.c
> > create mode 100644
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/
> > DxeSiliconPolicyUpdateLib/DxeSiliconPolicyUpdateLib.c
> > create mode 100644
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/
> > DxeSiliconPolicyUpdateLib/DxeSiliconPolicyUpdateLib.inf
> > create mode 100644
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/
> > PeiSiliconPolicyUpdateLib/PeiBoardPolicyUpdate.c
> > create mode 100644
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/
> > PeiSiliconPolicyUpdateLib/PeiSiliconPolicyUpdateLib.c
> > create mode 100644
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/
> > PeiSiliconPolicyUpdateLib/PeiSiliconPolicyUpdateLib.inf
> > create mode 100644
> >
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/build_config.cf
> > g
> > create mode 100644
> > Platform/Intel/KabylakeOpenBoardPkg/Library/BaseEcLib/EcCommands.c
> >
> > --
> > 2.31.1
> >
> >
> >
> >
> >
>
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#79332): https://edk2.groups.io/g/devel/message/79332
Mute This Topic: https://groups.io/mt/84876362/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-
More information about the edk2-devel-archive
mailing list