[edk2-devel] [PATCH 05/23] MdePkg: Add TdxProbeLib to probe Intel Tdx

[Gerd Hoffmann]

On Tue, Aug 17, 2021 at 12:14:44AM +0000, Min Xu wrote:
> On Monday, August 16, 2021 5:43 PM, Gerd Hoffmann wrote:
> > > +++ b/MdePkg/Library/TdxProbeLib/X64/TdProbe.nasm
> > 
> > Any specific reason why you code up your own instead of using the existing
> > cpuid functions in BaseLib ?
> Actually there is no specific reason. I am not sure if AsmCpuid is a preferred way
> in this situation?

I'm pretty sure it is preferred over duplicating code.

Early setup code (before stack setup where you can't do calls)
is a different story.

Also: Why there are separate TdxProbeLib + TdxLib libs?

take care,
  Gerd



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#79412): https://edk2.groups.io/g/devel/message/79412
Mute This Topic: https://groups.io/mt/84837894/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-