[edk2-devel] [PATCH] Package: CryptoPkg/BaseCryptLib: fix incorrect param order

[Stewart, Chris (SW Architect) via groups.io]

[PATCH] Package: CryptoPkg/BaseCryptLib: fix incorrect param order

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3550

Function ConvertAsn1TimeToEfiTime initializes timestamp to zeroes with SetMem, but the actual parameters are out of order.
The result is the SetMem operation has no effect. The fix is to put the actual parameters in the correct order.

Signed-off-by: Chris Stewart <chris.stewart at hp.com>
Reviewed-by: Liming Gao <gaoliming at byosoft.com.cn>
CC: Jiewen Yao <jiewen.yao at intel.com>
CC: Jian J Wang <jian.j.wang at intel.com>
CC: Xiaoyu Lu <xiaoyux.lu at intel.com>
CC: Guomin Jiang <guomin.jiang at intel.com>
---
 CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c b/CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c
index ff7f6488f2..970e9b94a0 100644
--- a/CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c
+++ b/CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c
@@ -155,7 +155,7 @@ ConvertAsn1TimeToEfiTime (
   }
 
   Str = (CONST CHAR8*)Asn1Time->data;
-  SetMem (EfiTime, 0, sizeof (EFI_TIME));
+  SetMem (EfiTime, sizeof (EFI_TIME), 0);
 
   Index = 0;
   if (Asn1Time->type == V_ASN1_UTCTIME) {               /* two digit year */
--
2.19.2.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#79468): https://edk2.groups.io/g/devel/message/79468
Mute This Topic: https://groups.io/mt/84966675/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-