[edk2-devel] [PATCH] UefiPayloadPkg: Add FV Guid for DXEFV and PLDFV

[Guo Dong]

Hi Zhiguang,
This patch just uses an actual FV GUID to replace the dummy FV GUID (all zero FV GUID) and no FV layout change, right?
If so, this change should not impact the coreboot FV parse to find the FV entrypoint.
https://github.com/coreboot/coreboot/blob/master/util/cbfstool/cbfs-mkpayload.c

Thanks,
Guo

From: Ni, Ray <ray.ni at intel.com>
Sent: Tuesday, August 24, 2021 4:45 AM
To: devel at edk2.groups.io; kingsumos at gmail.com; Dong, Guo <guo.dong at intel.com>
Cc: Liu, Zhiguang <zhiguang.liu at intel.com>; Tan, Dun <dun.tan at intel.com>
Subject: RE: [edk2-devel] [PATCH] UefiPayloadPkg: Add FV Guid for DXEFV and PLDFV

It seems like the coreboot cannot support FV that contains GUID in its header.

From: devel at edk2.groups.io<mailto:devel at edk2.groups.io> <devel at edk2.groups.io<mailto:devel at edk2.groups.io>> On Behalf Of King Sumo
Sent: Tuesday, August 24, 2021 1:02 AM
To: devel at edk2.groups.io<mailto:devel at edk2.groups.io>; Dong, Guo <guo.dong at intel.com<mailto:guo.dong at intel.com>>
Cc: Liu, Zhiguang <zhiguang.liu at intel.com<mailto:zhiguang.liu at intel.com>>
Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg: Add FV Guid for DXEFV and PLDFV

Hi All,

This patch broke the coreboot payload loading. Tested with:
build -a IA32 -a X64 -p UefiPayloadPkg/UefiPayloadPkg.dsc -b RELEASE -t GCC5 -D BOOTLOADER=COREBOOT

Basically the coreboot cbfstool reports the following error when creating the CBFS / flash image:
"Not a usable UEFI firmware volume"

Trying to boot coreboot results in an exception and the following error message:
"Payload not loaded"

Probably it broke the interface.

commit 4bac086e8e007c7143e33f87bb96238326d1d6ba
Author: Zhiguang Liu <zhiguang.liu at intel.com<mailto:zhiguang.liu at intel.com>>
Date:   Wed Jul 14 14:24:45 2021 +0800

    UefiPayloadPkg: Add FV Guid for DXEFV and PLDFV

    Signed-off-by: Zhiguang Liu <zhiguang.liu at intel.com<mailto:zhiguang.liu at intel.com>>
    Reviewed-by: Ray Ni <ray.ni at intel.com<mailto:ray.ni at intel.com>>
    Reviewed-by: Guo Dong <guo.dong at intel.com<mailto:guo.dong at intel.com>>


Kind regards,
Sumo

On Wed, Jul 14, 2021 at 1:08 PM Guo Dong <guo.dong at intel.com<mailto:guo.dong at intel.com>> wrote:

Signed-off-by: Guo Dong <guo.dong at intel.com<mailto:guo.dong at intel.com>>

> -----Original Message-----
> From: devel at edk2.groups.io<mailto:devel at edk2.groups.io> <devel at edk2.groups.io<mailto:devel at edk2.groups.io>> On Behalf Of
> Zhiguang Liu
> Sent: Tuesday, July 13, 2021 11:25 PM
> To: devel at edk2.groups.io<mailto:devel at edk2.groups.io>
> Subject: [edk2-devel] [PATCH] UefiPayloadPkg: Add FV Guid for DXEFV and
> PLDFV
>
> Signed-off-by: Zhiguang Liu <zhiguang.liu at intel.com<mailto:zhiguang.liu at intel.com>>
> ---
>  UefiPayloadPkg/UefiPayloadPkg.fdf | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/UefiPayloadPkg/UefiPayloadPkg.fdf
> b/UefiPayloadPkg/UefiPayloadPkg.fdf
> index 2d51fdbacb..041fed842c 100644
> --- a/UefiPayloadPkg/UefiPayloadPkg.fdf
> +++ b/UefiPayloadPkg/UefiPayloadPkg.fdf
> @@ -34,6 +34,7 @@ FV = PLDFV
>
>
>
> ##########################################################
> ######################
>
>  [FV.PLDFV]
>
> +FvNameGuid         = 96E75986-6FDD-491E-9FD5-35E21AC45B45
>
>  BlockSize          = $(FD_BLOCK_SIZE)
>
>  FvAlignment        = 16
>
>  ERASE_POLARITY     = 1
>
> @@ -62,6 +63,7 @@ FILE FV_IMAGE = 4E35FD93-9C72-4c15-8C4B-
> E77F1DB2D793 {
>
> ##########################################################
> ######################
>
>
>
>  [FV.DXEFV]
>
> +FvNameGuid         = 8063C21A-8E58-4576-95CE-089E87975D23
>
>  BlockSize          = $(FD_BLOCK_SIZE)
>
>  FvForceRebase      = FALSE
>
>  FvAlignment        = 16
>
> --
> 2.30.0.windows.2
>
>
>
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#77762): https://edk2.groups.io/g/devel/message/77762
> Mute This Topic: https://groups.io/mt/84196221/1781375
> Group Owner: devel+owner at edk2.groups.io<mailto:devel%2Bowner at edk2.groups.io>
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [guo.dong at intel.com<mailto:guo.dong at intel.com>]
> -=-=-=-=-=-=
>







-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#79779): https://edk2.groups.io/g/devel/message/79779
Mute This Topic: https://groups.io/mt/84196221/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/edk2-devel-archive/attachments/20210824/b7ae906b/attachment.htm>