[edk2-devel] [edk2-platforms][PATCH v1 3/4] MinPlatformPkg/Acpi: MinDsdt also installs all PcdAcpiTableStorageFile

[Nate DeSimone]

Hi Benjamin,

This is a compilation error in this patch. You have added the usage of gEfiMdeModulePkgTokenSpaceGuid to MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf but that GUID technically does not exist when this .inf is being compiled since the .inf only references the following DEC files:

  MdePkg/MdePkg.dec
  MinPlatformPkg/MinPlatformPkg.dec

You need to add MdeModulePkg/MdeModulePkg.dec

I suspect you missed this error because all the currently existing OpenBoardPkgs do not use MinDsdt thus far.

Thanks,
Nate 

-----Original Message-----
From: devel at edk2.groups.io <devel at edk2.groups.io> On Behalf Of Benjamin Doron
Sent: Wednesday, August 4, 2021 12:59 PM
To: devel at edk2.groups.io
Cc: Chiu, Chasel <chasel.chiu at intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone at intel.com>; Liming Gao <gaoliming at byosoft.com.cn>; Dong, Eric <eric.dong at intel.com>
Subject: [edk2-devel] [edk2-platforms][PATCH v1 3/4] MinPlatformPkg/Acpi: MinDsdt also installs all PcdAcpiTableStorageFile

Follow AcpiPlatformDxe (from which this module is derived) and install all ACPI tables added by board.

Cc: Chasel Chiu <chasel.chiu at intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone at intel.com>
Cc: Liming Gao <gaoliming at byosoft.com.cn>
Cc: Eric Dong <eric.dong at intel.com>
Signed-off-by: Benjamin Doron <benjamin.doron00 at gmail.com>
---
 Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c   | 1 +
 Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf | 2 ++
 2 files changed, 3 insertions(+)

diff --git a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c
index 9bc222453857..417cccc18b5a 100644
--- a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c
+++ b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c
@@ -227,6 +227,7 @@ InstallMinDsdt (
    Status = PublishAcpiTablesFromFv (&gEfiCallerIdGuid);   ASSERT_EFI_ERROR (Status);+  PublishAcpiTablesFromFv (PcdGetPtr (PcdAcpiTableStorageFile));      return EFI_SUCCESS; }diff --git a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf
index 3437bc489cd3..3e14c4e9a65d 100644
--- a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf
+++ b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf
@@ -41,6 +41,8 @@
   gMinPlatformPkgTokenSpaceGuid.PcdPciReservedMemBase   gMinPlatformPkgTokenSpaceGuid.PcdPciReservedMemLimit +  gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiTableStorageFile+ [Depex]   gEfiAcpiTableProtocolGuid           AND   gEfiFirmwareVolume2ProtocolGuid-- 
2.31.1



-=-=-=-=-=-=
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#78665): https://edk2.groups.io/g/devel/message/78665
Mute This Topic: https://groups.io/mt/84670596/1767664
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [nathaniel.l.desimone at intel.com] -=-=-=-=-=-=




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#79820): https://edk2.groups.io/g/devel/message/79820
Mute This Topic: https://groups.io/mt/84670596/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-