[edk2-devel] [PATCH EDK2 v1 1/1] MdeModulePkg/HiiDatabaseDxe:remove dead code block

[Dandan Bi]

Reviewed-by: Dandan Bi <dandan.bi at intel.com>


Thanks,
Dandan

> -----Original Message-----
> From: Wenyi Xie <xiewenyi2 at huawei.com>
> Sent: Thursday, August 26, 2021 9:16 AM
> To: devel at edk2.groups.io; Wang, Jian J <jian.j.wang at intel.com>; Wu, Hao A
> <hao.a.wu at intel.com>; Bi, Dandan <dandan.bi at intel.com>; Dong, Eric
> <eric.dong at intel.com>
> Cc: songdongkuang at huawei.com; xiewenyi2 at huawei.com
> Subject: [PATCH EDK2 v1 1/1] MdeModulePkg/HiiDatabaseDxe:remove dead
> code block
> 
> As the if statement outside has confirmed that
> BlockData->Name == NULL, so the if statement inside
> is always false.
> 
> Cc: Jian J Wang <jian.j.wang at intel.com>
> Cc: Hao A Wu <hao.a.wu at intel.com>
> Cc: Dandan Bi <dandan.bi at intel.com>
> Cc: Eric Dong <eric.dong at intel.com>
> Signed-off-by: Wenyi Xie <xiewenyi2 at huawei.com>
> ---
>  MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c
> b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c
> index d492b769d51c..17a914208c6d 100644
> --- a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c
> +++ b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c
> @@ -2871,9 +2871,6 @@ ParseIfrData (
>          //
>          if ((BlockData->Name == NULL) && ((BlockData->Offset + BlockData-
> >Width) > VarStorageData->Size)) {
>            Status = EFI_INVALID_PARAMETER;
> -          if (BlockData->Name != NULL) {
> -            FreePool (BlockData->Name);
> -          }
>            FreePool (BlockData);
>            goto Done;
>          }
> --
> 2.20.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#79877): https://edk2.groups.io/g/devel/message/79877
Mute This Topic: https://groups.io/mt/85151741/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-