[edk2-devel] [PATCH V5 2/2] OvmfPkg/ResetVector: Enable Intel TDX in ResetVector of Ovmf

[Gerd Hoffmann]

On Tue, Aug 31, 2021 at 03:09:08AM +0000, Xu, Min M wrote:
> On Monday, August 30, 2021 3:41 PM, Gerd Hoffmann wrote:
> >   Hi,
> > 
> > >  _TdxPageTable:
> > >     If 5-level page table is supported (GPAW is 52), a top level page
> > >     directory pointers (1 * 256TB entry) is generated in this page.
> > >  _OvmfPageTable:
> > >     Initial page table for standard Ovmf.
> > 
> > Hmm, isn't 5-level paging independent from TDX?  Why mix the two?
> > 
> > I think a top level page directory should be added to the standard ovmf initial
> > page tables instead, and setting up 5-level paging should not happen in tdx-
> > specific code.
> In current Ovmf implementation (OvmfPkg/ResetVector/Ia32/PageTables64.asm)
> there are 6 pages reserved for initial page tables. It doesn't support 5-level paging.

Sure.  And I think we should add proper 5-level paging support to the
current ovmf implementation instead of adding hacks to the tdx code.

take care,
  Gerd



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#79978): https://edk2.groups.io/g/devel/message/79978
Mute This Topic: https://groups.io/mt/85242569/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-