[edk2-devel] [PATCH 2/2] UefiCpuPkg/MpInitLib: Use XADD to avoid lock acquire/release

[Ni, Ray]

> 
> (1) For more clarity, I would suggest
> 
>   lock xadd  dword [edi], ebx
> 
> (even though "ebx" already specifies the width, yes)
> 
> Applies to the X64 version too.

OK.


> 
> 
> > +    inc        ebx                              ; EBX is CpuNumber
> >
> > +    ; program stack
> 
> (2) This change belongs in a separate patch. The X64 version already has
> this comment, and making both versions makes sense. But touching
> anything "stack-related" in the current patch is very confusing to me. 

OK.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#71246): https://edk2.groups.io/g/devel/message/71246
Mute This Topic: https://groups.io/mt/80372087/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-