[edk2-devel] [PATCH 1/1] DynamicTablesPkg/AmlLib: Remove unused variables

[Sami Mujawar]

Pushed as 2e1e8c35f317..4f4d862c1c72

Thanks,

Sami Mujawar

-----Original Message-----
From: Leif Lindholm <leif at nuviainc.com> 
Sent: 15 February 2021 08:04 PM
To: Pierre Gondois <Pierre.Gondois at arm.com>
Cc: devel at edk2.groups.io; Alexei Fedorov <Alexei.Fedorov at arm.com>; Sami Mujawar <Sami.Mujawar at arm.com>
Subject: Re: [PATCH 1/1] DynamicTablesPkg/AmlLib: Remove unused variables

On Mon, Feb 15, 2021 at 18:29:57 +0000, Pierre.Gondois at arm.com wrote:
> From: Pierre Gondois <Pierre.Gondois at arm.com>
> 
> Building the DynamicTablesPkg for a NOOPT target
> fails because unused variables are set.
> Remove these variables.
> 
> Fixes: d9800046ea43
> Reported-by: Leif Lindholm <leif at nuviainc.com>
> Signed-off-by: Pierre Gondois <Pierre.Gondois at arm.com>

Reviewed-by: Leif Lindholm <leif at nuviainc.com>
(also build tested)

Thanks for quick turnaround!

> ---
>  .../Library/Common/AmlLib/NameSpace/AmlNameSpace.c         | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/DynamicTablesPkg/Library/Common/AmlLib/NameSpace/AmlNameSpace.c b/DynamicTablesPkg/Library/Common/AmlLib/NameSpace/AmlNameSpace.c
> index 2d055e9fb964..8da47405af85 100644
> --- a/DynamicTablesPkg/Library/Common/AmlLib/NameSpace/AmlNameSpace.c
> +++ b/DynamicTablesPkg/Library/Common/AmlLib/NameSpace/AmlNameSpace.c
> @@ -1,7 +1,7 @@
>  /** @file
>    AML NameSpace.
>  
> -  Copyright (c) 2019 - 2020, Arm Limited. All rights reserved.<BR>
> +  Copyright (c) 2019 - 2021, Arm Limited. All rights reserved.<BR>
>  
>    SPDX-License-Identifier: BSD-2-Clause-Patent
>  **/
> @@ -1075,10 +1075,8 @@ AmlEnumeratePathCallback (
>    AML_PATH_SEARCH_CONTEXT   * PathSearchContext;
>  
>    AML_STREAM                * SearchPathBStream;
> -  CHAR8                     * SearchedPath;
>  
>    AML_STREAM                * CurrNodePathBStream;
> -  CHAR8                     * CurrNodePath;
>    UINT32                      CurrNodePathSize;
>  
>    ContinueEnum = TRUE;
> @@ -1123,9 +1121,6 @@ AmlEnumeratePathCallback (
>      goto exit_handler;
>    }
>  
> -  SearchedPath = (CHAR8*)AmlStreamGetCurrPos (SearchPathBStream);
> -  CurrNodePath = (CHAR8*)AmlStreamGetCurrPos (CurrNodePathBStream);
> -
>    // Get the raw AML absolute pathname of the current node.
>    Status1 = AmlGetRawNameSpacePath (Node, 0, CurrNodePathBStream);
>    if (EFI_ERROR (Status1)) {
> -- 
> 2.17.1
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#71692): https://edk2.groups.io/g/devel/message/71692
Mute This Topic: https://groups.io/mt/80660483/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-