Re: 回复: [edk2-devel] [PATCH 1/1] ArmPkg: Fix ARM ProcessorSubClassDxe build

[Sami Mujawar]

Hi Liming,

We are working to get EDK2 Open CI enabled for ArmPkg and ArmPlatformPkg. We are doing some initial cleanup before the CI is enabled.

Regards,

Sami Mujawar

________________________________
From: devel at edk2.groups.io <devel at edk2.groups.io> on behalf of Rebecca Cran via groups.io <rebecca=bsdio.com at groups.io>
Sent: Thursday, 18 February 2021, 3:42 am
To: devel at edk2.groups.io; gaoliming at byosoft.com.cn; rebecca at nuviainc.com
Cc: 'Leif Lindholm'; 'Ard Biesheuvel'
Subject: Re: 回复: [edk2-devel] [PATCH 1/1] ArmPkg: Fix ARM ProcessorSubClassDxe build

Liming,

It was found via Linaro's CI environment, but not EDK2's.
I'm planning to set up my own Jenkins server to run CI to catch problems
like this before they're committed. It'll also let me test OvmfPkg/Bhyve
builds too.

--
Rebecca Cran

On 2/17/21 8:33 PM, gaoliming wrote:
> Rebecca:
>    Is this issue detected in open CI environment?
>
> Thanks
> Liming
>> -----�ʼ�ԭ��-----
>> ������: bounce+27952+71573+4905953+8761045 at groups.io
>> <bounce+27952+71573+4905953+8761045 at groups.io> ���� Rebecca Cran
>> ����ʱ��: 2021��2��10�� 23:05
>> �ռ���: devel at edk2.groups.io
>> ����: Rebecca Cran <rebecca at nuviainc.com>; Leif Lindholm
>> <leif at nuviainc.com>; Ard Biesheuvel <ardb+tianocore at kernel.org>
>> ����: [edk2-devel] [PATCH 1/1] ArmPkg: Fix ARM ProcessorSubClassDxe build
>>
>> The ARM ProcessorSubClassDxe build was broken due to changes in the
>> SmbiosProcessor API and an unused variable.
>>
>> Signed-off-by: Rebecca Cran <rebecca at nuviainc.com>
>> ---
>>   ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessorArm.c | 6
>> ++----
>>   1 file changed, 2 insertions(+), 4 deletions(-)
>>
>> diff --git
>> a/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessorArm.c
>> b/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessorArm.c
>> index 0be4403c765f..c78bd41a7e06 100644
>> ---
>> a/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessorArm.c
>> +++
>> b/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessorArm.c
>> @@ -22,7 +22,7 @@
>>       @return The cache size.
>>   **/
>>   UINT64
>> -ArmGetCacheSize (
>> +SmbiosProcessorGetCacheSize (
>>     IN UINT8   CacheLevel,
>>     IN BOOLEAN DataCache,
>>     IN BOOLEAN UnifiedCache
>> @@ -66,14 +66,13 @@ ArmGetCacheSize (
>>       @return The cache associativity.
>>   **/
>>   UINT32
>> -ArmGetCacheAssociativity (
>> +SmbiosProcessorGetCacheAssociativity (
>>     IN UINT8   CacheLevel,
>>     IN BOOLEAN DataCache,
>>     IN BOOLEAN UnifiedCache
>>     )
>>   {
>>     CCSIDR_DATA  Ccsidr;
>> -  CCSIDR2_DATA Ccsidr2;
>>     CSSELR_DATA  Csselr;
>>     BOOLEAN      CcidxSupported;
>>     UINT32       Associativity;
>> @@ -88,7 +87,6 @@ ArmGetCacheAssociativity (
>>     CcidxSupported = ArmHasCcidx ();
>>
>>     if (CcidxSupported) {
>> -    Ccsidr2.Data = ReadCCSIDR2 (Csselr.Data);
>>       Associativity = Ccsidr.BitsCcidxAA32.Associativity + 1;
>>     } else {
>>       Associativity = Ccsidr.BitsNonCcidx.Associativity + 1;
>> --
>> 2.26.2
>>
>>
>>
>>
>>
>
>
>
>
>
>
>
>










-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#71782): https://edk2.groups.io/g/devel/message/71782
Mute This Topic: https://groups.io/mt/80722048/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/edk2-devel-archive/attachments/20210218/562442b0/attachment.htm>