[edk2-devel] [PATCH 1/1] uefi-sct/SctPkg: format string BBTestFatToStrFunctionAutoTest

[G Edhaya Chandran]

Reviewed-By: G Edhaya Chandran <edhaya.chandran at arm.com>

> -----Original Message-----
> From: Heinrich Schuchardt <xypron.glpk at gmx.de>
> Sent: 02 January 2021 01:22
> To: EDK II Development <devel at edk2.groups.io>
> Cc: Eric Jin <eric.jin at intel.com>; G Edhaya Chandran
> <Edhaya.Chandran at arm.com>; Barton Gao <gaojie at byosoft.com.cn>; Arvin
> Chen <arvinx.chen at intel.com>; Samer El-Haj-Mahmoud <Samer.El-Haj-
> Mahmoud at arm.com>; Heinrich Schuchardt <xypron.glpk at gmx.de>
> Subject: [PATCH 1/1] uefi-sct/SctPkg: format string
> BBTestFatToStrFunctionAutoTest
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3146
>
> EFI_UNICODE_COLLATION_PROTOCOL.FatToStr() expects as parameter Fat an
> ASCII string not a wide string.
>
> In function BBTestFatToStrFunctionAutoTest() this string is supplied as
> TestData[Index].
>
> When printing this string we cannot use "%s" but we must use "%a".
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
> ---
>  .../BlackBoxTest/UnicodeCollation2BBTestFunction.c          | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/UnicodeCollation2/BlackBoxTest/Unicod
> eCollation2BBTestFunction.c b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/UnicodeCollation2/BlackBoxTest/Unicod
> eCollation2BBTestFunction.c
> index 8bf5170f..22b57f21 100644
> --- a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/UnicodeCollation2/BlackBoxTest/Unicod
> eCollation2BBTestFunction.c
> +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/UnicodeCollation2/Black
> +++ BoxTest/UnicodeCollation2BBTestFunction.c
> @@ -636,7 +636,7 @@ BBTestFatToStrFunctionAutoTest (
>                     AssertionType,
>                     gUnicodeCollationFunctionTestAssertionGuid007,
>                     L"EFI_UNICODE_COLLATION_PROTOCOL.FatToStr - Verification of
> FatToStr interface",
> -                   L"%a:%d: Fat='%s', FatToStr='%s', FatSize=%d, StrSize=%d",
> +                   L"%a:%d: Fat='%a', FatToStr='%s', FatSize=%d,
> + StrSize=%d",
>                     __FILE__,
>                     (UINTN)__LINE__,
>                     TestData[Index],
> @@ -668,7 +668,7 @@ BBTestFatToStrFunctionAutoTest (
>                       AssertionType,
>                       gUnicodeCollationFunctionTestAssertionGuid008,
>                       L"EFI_UNICODE_COLLATION_PROTOCOL.FatToStr - Verification
> of FatToStr interface",
> -                     L"%a:%d: Fat='%s', FatToStr='%s', FatSize=%d, StrSize=%d",
> +                     L"%a:%d: Fat='%a', FatToStr='%s', FatSize=%d,
> + StrSize=%d",
>                       __FILE__,
>                       (UINTN)__LINE__,
>                       TestData[Index],
> @@ -701,7 +701,7 @@ BBTestFatToStrFunctionAutoTest (
>                       AssertionType,
>                       gUnicodeCollationFunctionTestAssertionGuid009,
>                       L"EFI_UNICODE_COLLATION_PROTOCOL.FatToStr - Verification
> of FatToStr interface",
> -                     L"%a:%d: Fat='%s', FatToStr='%s', FatSize=%d, StrSize=%d",
> +                     L"%a:%d: Fat='%a', FatToStr='%s', FatSize=%d,
> + StrSize=%d",
>                       __FILE__,
>                       (UINTN)__LINE__,
>                       TestData[Index],
> --
> 2.29.2

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#69716): https://edk2.groups.io/g/devel/message/69716
Mute This Topic: https://groups.io/mt/79364715/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-