[edk2-devel] [PATCH v1] uefi-sct/SctPkg: Changed compiler check from greater 5 to equal to 5

[G Edhaya Chandran]

Reviewed-By: G Edhaya Chandran <edhaya.chandran at arm.com>

> -----Original Message-----
> From: Heinrich Schuchardt <xypron.glpk at gmx.de>
> Sent: 14 December 2020 20:30
> To: Joseph Hemann <Joseph.Hemann at arm.com>; devel at edk2.groups.io
> Cc: Joseph Hemann <Joseph.heman at arm.com>; G Edhaya Chandran
> <Edhaya.Chandran at arm.com>; Eric Jin <eric.jin at intel.com>; Irene Park
> <ipark at nvidia.com>; Samer El-Haj-Mahmoud <Samer.El-Haj-
> Mahmoud at arm.com>; Stuart Yoder <Stuart.Yoder at arm.com>
> Subject: Re: [PATCH v1] uefi-sct/SctPkg: Changed compiler check from greater
> 5 to equal to 5
>
> On 14.12.20 15:35, Joseph Hemann wrote:
> > From: Joseph Hemann <Joseph.heman at arm.com>
> >
> > gcc compilers versions 5.* also need to be converted from string to
> > integer before testing
> >
> > Cc: G Edhaya Chandran <Edhaya.Chandran at arm.com>
> > Cc: Eric Jin <eric.jin at intel.com>
> > Cc: Irene Park <ipark at nvidia.com>
> > Cc: Heinrich Schuchardt <xypron.glpk at gmx.de>
> > Cc: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud at arm.com>
> > Cc: Stuart Yoder <Stuart.Yoder at arm.com>
> > Signed-off-by: Joseph Hemann <Joseph.heman at arm.com>
> > Change-Id: Ica60b6629f698d5f5c61b861ac4aefcc9cd24b7a
>
> Reviewed-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
>
> > ---
> >  uefi-sct/SctPkg/build.sh | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/uefi-sct/SctPkg/build.sh b/uefi-sct/SctPkg/build.sh index
> > 37667711..ba9babe7 100755
> > --- a/uefi-sct/SctPkg/build.sh
> > +++ b/uefi-sct/SctPkg/build.sh
> > @@ -56,7 +56,7 @@ function get_gcc_version  {
> >  gcc_version=$($1 -dumpversion)
> >
> > -if [ ${gcc_version%%.*} -gt 5 ]; then
> > +if [ ${gcc_version%%.*} -ge 5 ]; then
> >  gcc_version=5
> >  fi
> >
> >

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#69717): https://edk2.groups.io/g/devel/message/69717
Mute This Topic: https://groups.io/mt/78951930/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-