[edk2-devel] [PATCH 2/2] uefi-sct/SctPkg: allowable NotifyTpl in CreateEvent

Heinrich Schuchardt xypron.glpk at gmx.de
Wed Jan 6 12:42:15 UTC 2021


REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3057

According to table Table 27. TPL Restrictions in UEFI spec 2.8 B:

Event Notification Levels must be "> TPL_APPLICATION" and "<= TPL_HIGH_LEVEL".

In the conformance test for CreateEvent() check that TPL_APPLICATION
results in EFI_INVALID_PARAMETER if the event can be notified.

In the functional tests check that events can be created with
TPL_HIGH_LEVEL.

Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
---
 .../EventTimerTaskPriorityServicesBBTestCreateEvent.c        | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c
index f71d6d21b8db..5fc0614192bb 100644
--- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c
+++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c
@@ -190,6 +190,7 @@ BBTestCreateEvent_Conf_Sub1 (
   EFI_TPL             NotifyTpls[] = {
                         TPL_CALLBACK,
                         TPL_NOTIFY,
+			TPL_HIGH_LEVEL,
                         0
                       };
   EFI_TEST_ASSERTION  AssertionType;
@@ -263,6 +264,7 @@ BBTestCreateEvent_Conf_Sub2 (
   EFI_TPL             InvalidNotifyTpls[] = {
                         (EFI_TPL) (TPL_HIGH_LEVEL + 1),
                         (EFI_TPL) (TPL_APPLICATION - 1),
+                        (EFI_TPL) TPL_APPLICATION,
                         (EFI_TPL) -1,
                         0
                       };
@@ -340,6 +342,7 @@ BBTestCreateEvent_Conf_Sub3 (
   EFI_TPL             NotifyTpls[] = {
                         TPL_CALLBACK,
                         TPL_NOTIFY,
+			TPL_HIGH_LEVEL,
                         0
                       };
   EFI_TEST_ASSERTION  AssertionType;
@@ -404,6 +407,7 @@ BBTestCreateEvent_Conf_Sub4 (
   EFI_TPL             NotifyTpls[] = {
                         TPL_CALLBACK,
                         TPL_NOTIFY,
+			TPL_HIGH_LEVEL,
                         0
                       };
   EFI_TEST_ASSERTION  AssertionType;
@@ -478,6 +482,7 @@ BBTestCreateEvent_Func_Sub1 (
   EFI_TPL             NotifyTpls[] = {
                         TPL_CALLBACK,
                         TPL_NOTIFY,
+			TPL_HIGH_LEVEL,
                         0
                       };
   EFI_TEST_ASSERTION  AssertionType;
--
2.29.2



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#69815): https://edk2.groups.io/g/devel/message/69815
Mute This Topic: https://groups.io/mt/79473463/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-






More information about the edk2-devel-archive mailing list