[edk2-devel] [PATCH v1 00/25] Fix Ecc reported errors in ArmPkg

[Ard Biesheuvel]

On 12/16/20 6:21 PM, Pierre.Gondois at arm.com wrote:
> From: Pierre Gondois <Pierre.Gondois at arm.com>
> 
> The Ecc tools available in the BaseTools package checks for
> good practice coding standards. Some errors reported while
> running Ecc on the ArmPkg require modifications.
> 
> The changes can be seen at: https://github.com/PierreARM/edk2/commits/1552_Ecc_ArmPkg_v1
> 
> Pierre Gondois (25):
>   ArmPkg: Format header to fix Ecc crash in ArmMmuLib
>   ArmPkg: Fix Ecc error 3002 in CompilerIntrinsicsLib
>   ArmPkg: Fix Ecc error 3002 in OpteeLib
>   ArmPkg: Fix Ecc error 3002 in ArmMmuLib
>   ArmPkg: Fix Ecc error 3002 in TimerDxe
>   ArmPkg: Fix Ecc error 3002 in MmCommunicationDxe
>   ArmPkg: Fix Ecc error 3002 in CpuDxe
>   ArmPkg: Fix Ecc error 3002 in SemihostFs
>   ArmPkg: Fix Ecc error 3002 in ArmDisassemblerLib
>   ArmPkg: Fix Ecc error 3001 in SemihostFs
>   ArmPkg: Fix Ecc error 5005 in CpuDxe
>   ArmPkg: Fix Ecc error 5005 in ArmExceptionLib
>   ArmPkg: Fix Ecc error 5007 in CompilerIntrinsicsLib
>   ArmPkg: Fix Ecc error 5007 in ArmScmiDxe
>   ArmPkg: Fix Ecc error 5007 in CpuDxe
>   ArmPkg: Fix Ecc error 5007 in TimerDxe
>   ArmPkg: Fix Ecc error 5007 in SemihostFs
>   ArmPkg: Fix Ecc error 5007 in ArmCacheMaintenanceLib
>   ArmPkg: Fix Ecc error 5007 in ArmDisassemblerLib
>   ArmPkg: Fix Ecc error 5007 in ArmLib
>   ArmPkg: Fix Ecc error 5007 in ArmMmuLib
>   ArmPkg: Fix Ecc error 5007 in SemiHostingSerialPortLib
>   ArmPkg: Fix Ecc error 5007 in SemihostLib
>   ArmPkg: Fix Ecc error 5007 in StandaloneMmMmuLib
>   ArmPkg: Fix Ecc error 5007 in DefaultExceptionHandlerLib
> 

Reviewed-by: Ard Biesheuvel <ard.biesheuvel at arm.com>

Merged as #1305 (with a few tweaks)

Thanks Pierre!


>  ArmPkg/Drivers/ArmScmiDxe/Scmi.c              |  5 ++-
>  ArmPkg/Drivers/ArmScmiDxe/ScmiClockProtocol.c |  8 ++--
>  ArmPkg/Drivers/CpuDxe/AArch64/Mmu.c           |  8 ++--
>  ArmPkg/Drivers/CpuDxe/Arm/Mmu.c               | 14 +++----
>  ArmPkg/Drivers/CpuDxe/Exception.c             |  8 ++--
>  .../MmCommunicationDxe/MmCommunication.c      |  4 +-
>  ArmPkg/Drivers/TimerDxe/TimerDxe.c            |  7 ++--
>  ArmPkg/Filesystem/SemihostFs/Arm/SemihostFs.c | 25 ++++++-----
>  .../ArmCacheMaintenanceLib.c                  | 13 +++---
>  .../ArmDisassemblerLib/ArmDisassembler.c      | 11 ++++-
>  .../Library/ArmExceptionLib/ArmExceptionLib.c |  5 ++-
>  ArmPkg/Library/ArmLib/ArmLib.c                | 20 +++------
>  .../Library/ArmMmuLib/AArch64/ArmMmuLibCore.c |  2 +-
>  .../AArch64/ArmMmuPeiLibConstructor.c         | 14 +++----
>  .../Library/ArmMmuLib/Arm/ArmMmuLibUpdate.c   | 34 +++++++--------
>  .../Library/CompilerIntrinsicsLib/memcmp_ms.c | 10 +++--
>  ArmPkg/Library/CompilerIntrinsicsLib/memcpy.c | 11 +++--
>  .../Library/CompilerIntrinsicsLib/memcpy_ms.c | 11 +++--
>  .../CompilerIntrinsicsLib/memmove_ms.c        | 14 +++++--
>  ArmPkg/Library/CompilerIntrinsicsLib/memset.c |  8 +++-
>  .../Library/CompilerIntrinsicsLib/memset_ms.c |  8 +++-
>  .../Arm/DefaultExceptionHandler.c             | 41 ++++++++++---------
>  ArmPkg/Library/OpteeLib/Optee.c               |  7 ++--
>  .../SemiHostingSerialPortLib/SerialPortLib.c  |  8 +++-
>  ArmPkg/Library/SemihostLib/SemihostLib.c      |  6 +--
>  .../AArch64/ArmMmuStandaloneMmLib.c           | 13 +++---
>  26 files changed, 182 insertions(+), 133 deletions(-)
> 
> --
> 2.17.1
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#69846): https://edk2.groups.io/g/devel/message/69846
Mute This Topic: https://groups.io/mt/79006179/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-