[edk2-devel] [PATCH v5 00/23] ArmPkg, MdePkg: Add Universal/Smbios, and related changes

[Leif Lindholm]

On Fri, Jan 08, 2021 at 08:55:33 -0700, Rebecca Cran wrote:
> On 1/5/21 3:14 PM, Samer El-Haj-Mahmoud wrote:
> 
> > I did quick review of parts of the patch, mostly compared against the RPi4 implementation which has been validated in the past.
> > 
> > On the platform on which you are implementing this, are you able to run the FWTS SMBIOS tests and confirm that everything passes?
> > 
> > Also, one question on the patch in general: Any reason why not to include the nuvia copyright header in these files?
> 
> 
> I haven't run the FWTS SMBIOS tests, but I'll make sure to run them before I
> submit the next version of the patch series.
> 
> I'm never sure whether the changes I'm making are large enough to justify
> adding my own or NUVIA's copyright. Since I have now made quite a few
> changes to the original sources, I'll add it.

There are companies that require their employees to add their
copyright for fixing a typo in a comment. So in this project, there is
effectively no change too small.

With my experience from other projects, I tend to apply the "about
three lines of code" bar.

/
    Leif




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#70063): https://edk2.groups.io/g/devel/message/70063
Mute This Topic: https://groups.io/mt/79438395/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-