回复: [edk2-devel] [Patch 0/2] Convert Split tool to python

[gaoliming]

Bob:
  Have you plan to convert all C tools to Python tools? Or only some ones?
Can you share your planning for the changes in BaseTools?
  
  And, I see you also add unittest for new split tool. Can you introduce the
unittest framework for python tool? If so, new added tool can follow the
same way to add unittest. 

Thanks
Liming
> -----邮件原件-----
> 发件人: bounce+27952+70232+4905953+8761045 at groups.io
> <bounce+27952+70232+4905953+8761045 at groups.io> 代表 Bob Feng
> 发送时间: 2021年1月13日 17:56
> 收件人: devel at edk2.groups.io
> 主题: [edk2-devel] [Patch 0/2] Convert Split tool to python
> 
> There are 2 reasons to convert Split tool from C to Python.
> 
> 1. We are in the process of moving the Basetools Python code
> 
> to a separate repository. But there still are many C tools under
> 
> edk2/BaseTools. To make all Basetools be in the separate repo,
> 
> we can convert the C tools to Python tools.
> 
> 2. The original Split tool is very slow. This python tool can reduce
> 
> 90% time
> 
> Bob Feng (2):
>   BaseTools: Convert Split tool to python
>   BaseTools: Add unittest for Split tool
> 
>  BaseTools/Source/C/Split/Split.c            | 466 --------------------
>  BaseTools/BinWrappers/PosixLike/Split       |  31 +-
>  BaseTools/BinWrappers/WindowsLike/Split.bat |   3 +
>  BaseTools/Source/C/GNUmakefile              |   1 -
>  BaseTools/Source/C/Makefile                 |   1 -
>  BaseTools/Source/C/Split/GNUmakefile        |  17 -
>  BaseTools/Source/C/Split/Makefile           |  16 -
>  BaseTools/Source/Python/Split/Split.py      | 203 +++++++++
>  BaseTools/Source/Python/Split/__init__.py   |  10 +
>  BaseTools/Source/Python/tests/test_split.py | 101 +++++
>  10 files changed, 325 insertions(+), 524 deletions(-)
>  delete mode 100644 BaseTools/Source/C/Split/Split.c
>  create mode 100644 BaseTools/BinWrappers/WindowsLike/Split.bat
>  delete mode 100644 BaseTools/Source/C/Split/GNUmakefile
>  delete mode 100644 BaseTools/Source/C/Split/Makefile
>  create mode 100644 BaseTools/Source/Python/Split/Split.py
>  create mode 100644 BaseTools/Source/Python/Split/__init__.py
>  create mode 100644 BaseTools/Source/Python/tests/test_split.py
> 
> --
> 2.29.1.windows.1
> 
> 
> 
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#70232): https://edk2.groups.io/g/devel/message/70232
> Mute This Topic: https://groups.io/mt/79647273/4905953
> Group Owner: devel+owner at edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub
> [gaoliming at byosoft.com.cn]
> -=-=-=-=-=-=
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#70262): https://edk2.groups.io/g/devel/message/70262
Mute This Topic: https://groups.io/mt/79665827/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-