回复: [edk2-devel] [PATCH v3 01/18] BaseTools: Ecc/exception: Added _ModuleEntryPoint into exception list

[gaoliming]

Qin:

 This change makes sense. Can you let me know which case trigs this ECC
issue? Does your patch include such case?

 

Thanks

Liming

发件人: Kun Qin <kun.q at outlook.com> 
发送时间: 2021年1月21日 9:37
收件人: devel at edk2.groups.io
抄送: Bob Feng <bob.c.feng at intel.com>; Liming Gao
<gaoliming at byosoft.com.cn>; Yuwei Chen <yuwei.chen at intel.com>
主题: RE: [edk2-devel] [PATCH v3 01/18] BaseTools: Ecc/exception: Added
_ModuleEntryPoint into exception list

 

Hi Bob/Liming/Yuwei,

 

Do you mind providing some feedback on this patch? This is to unblock the
second patch (adding driver entry point instance for Standalone X64) of this
patch series. Thanks in advance!

 

Regards,

Kun

 

From: Kun Qin <mailto:kun.q at outlook.com> 
Sent: Thursday, January 14, 2021 14:34
To: devel at edk2.groups.io <mailto:devel at edk2.groups.io> 
Cc: Bob Feng <mailto:bob.c.feng at intel.com> ; Liming Gao
<mailto:gaoliming at byosoft.com.cn> ; Yuwei Chen <mailto:yuwei.chen at intel.com>

Subject: [edk2-devel] [PATCH v3 01/18] BaseTools: Ecc/exception: Added
_ModuleEntryPoint into exception list

 

Function '_ModuleEntryPoint' is a pre-defined interface for various EFI
module types and should not be caught violating EFI coding style. This
change added '_ModuleEntryPoint' into exception list to fix EFI coding
style error 8006 during CI build.

Cc: Bob Feng <bob.c.feng at intel.com <mailto:bob.c.feng at intel.com> >
Cc: Liming Gao <gaoliming at byosoft.com.cn <mailto:gaoliming at byosoft.com.cn> >
Cc: Yuwei Chen <yuwei.chen at intel.com <mailto:yuwei.chen at intel.com> >

Signed-off-by: Kun Qin <kun.q at outlook.com <mailto:kun.q at outlook.com> >
---

Notes:
    v3:
    - Newly added to fix CI build on changing '_ModuleEntryPoint'

 BaseTools/Source/Python/Ecc/exception.xml | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/BaseTools/Source/Python/Ecc/exception.xml
b/BaseTools/Source/Python/Ecc/exception.xml
index 8133904fbc7f..f2334aab8e52 100644
--- a/BaseTools/Source/Python/Ecc/exception.xml
+++ b/BaseTools/Source/Python/Ecc/exception.xml
@@ -296,6 +296,10 @@
     <KeyWord>_DriverUnloadHandler</KeyWord>
     <ErrorID>8006</ErrorID>
   </Exception>
+  <Exception>
+    <KeyWord>_ModuleEntryPoint</KeyWord>
+    <ErrorID>8006</ErrorID>
+  </Exception>
   <Exception>
     <KeyWord>ASSERT</KeyWord>
     <ErrorID>10015</ErrorID>
-- 
2.30.0.windows.1





 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#70607): https://edk2.groups.io/g/devel/message/70607
Mute This Topic: https://groups.io/mt/79994517/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/edk2-devel-archive/attachments/20210121/3087dd8d/attachment.htm>