[edk2-devel] [PATCH v1 00/27] Fix Ecc reported errors in ArmPkg

PierreGondois pierre.gondois at arm.com
Thu Jan 21 09:50:52 UTC 2021


From: Pierre Gondois <Pierre.Gondois at arm.com>

The Ecc tools available in the BaseTools package checks for
good practice coding standards. Some errors reported while
running Ecc on the ArmPkg require modifications.

The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc_ArmPkg_BIS_v1

Pierre Gondois (27):
  ArmPkg: Fix Ecc error 8001 in Chipset
  ArmPkg: Fix Ecc error 8001 in SemihostLib
  ArmPkg: Fix Ecc error 8001 in Chipset
  ArmPkg: Fix Ecc error 8001 in ArmArchTimerLib
  ArmPkg: Fix Ecc error 9005 in CpuDxe
  ArmPkg: Fix Ecc error 10006 in ArmPkg.dsc
  ArmPkg: Fix Ecc error 10016 in StandaloneMmMmuLib
  ArmPkg: Fix Ecc error 10014 in ArmScmiDxe
  ArmPkg: Fix Ecc error 10014 in GenericWatchdogDxe
  ArmPkg: Fix Ecc error 10014 in MmCommunicationDxe
  ArmPkg: Fix Ecc error 10014 in SemihostLib
  ArmPkg: Remove ArmGic/ArmGicSecLib.c
  ArmPkg: Fix Ecc error 5003 in ArmExceptionLib
  ArmPkg: Fix Ecc error 6001 in MmCommunicationDxe
  ArmPkg: Fix Ecc error 6001 in ArmSoftFloatLib
  ArmPkg: Rename include guard in ArmGicLib.h
  ArmPkg: Fix Ecc error 7008 for SCMI_CLOCK_RATE
  ArmPkg: Fix Ecc error 7008 for OPTEE_MESSAGE_PARAM
  ArmPkg: Fix Ecc error 8005/8007 in ArmDisassemblerLib
  ArmPkg: Fix Ecc error 8005 for SCMI_PROTOCOL_ID
  ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_TYPE
  ArmPkg: Fix Ecc error 8005 for SCMI_STATUS
  ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_ID
  ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_ID_BASE
  ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_ID_CLOCK
  ArmPkg: Fix Ecc error 8005 for SCMI_CLOCK_RATE_FORMAT
  ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_ID_PERFORMANCE

 ArmPkg/ArmPkg.dsc                             |   6 +-
 ArmPkg/Drivers/ArmGic/ArmGicSecLib.c          |  58 -------
 ArmPkg/Drivers/ArmScmiDxe/ArmScmiDxe.inf      |   9 +-
 .../ArmScmiPerformanceProtocolPrivate.h       |   4 +-
 ArmPkg/Drivers/ArmScmiDxe/Scmi.c              |  10 +-
 ArmPkg/Drivers/ArmScmiDxe/ScmiBaseProtocol.c  |  24 +--
 ArmPkg/Drivers/ArmScmiDxe/ScmiClockProtocol.c |  44 ++---
 ArmPkg/Drivers/ArmScmiDxe/ScmiDxe.c           |  10 +-
 .../ArmScmiDxe/ScmiPerformanceProtocol.c      |  30 ++--
 ArmPkg/Drivers/ArmScmiDxe/ScmiPrivate.h       |  48 +++---
 ArmPkg/Drivers/CpuDxe/CpuMpCore.c             |   4 +-
 .../GenericWatchdogDxe/GenericWatchdogDxe.inf |   3 +-
 .../MmCommunicationDxe/MmCommunicate.h        |   8 +-
 .../MmCommunicationDxe/MmCommunication.inf    |   3 +-
 ArmPkg/Include/Chipset/AArch64.h              |  12 +-
 ArmPkg/Include/Chipset/AArch64Mmu.h           |   4 +-
 ArmPkg/Include/Chipset/ArmCortexA5x.h         |   8 +-
 ArmPkg/Include/Chipset/ArmV7.h                |   4 +-
 ArmPkg/Include/Library/ArmGicLib.h            |   8 +-
 ArmPkg/Include/Library/OpteeLib.h             |  11 +-
 ArmPkg/Include/Protocol/ArmScmiBaseProtocol.h |  10 +-
 .../Include/Protocol/ArmScmiClock2Protocol.h  |   6 +-
 .../Include/Protocol/ArmScmiClockProtocol.h   |  32 ++--
 .../Protocol/ArmScmiPerformanceProtocol.h     |  14 +-
 .../Library/ArmArchTimerLib/ArmArchTimerLib.c |  12 +-
 .../ArmDisassemblerLib/ArmDisassembler.c      | 159 +++++++++---------
 .../ArmDisassemblerLib/ThumbDisassembler.c    | 158 ++++++++---------
 .../AArch64/AArch64Exception.c                |   4 +-
 .../AArch64/ExceptionSupport.S                |  10 +-
 .../ArmExceptionLib/Arm/ArmException.c        |   5 +-
 ArmPkg/Library/ArmSoftFloatLib/platform.h     |   6 +
 ArmPkg/Library/SemihostLib/SemihostLib.c      |  26 +--
 ArmPkg/Library/SemihostLib/SemihostLib.inf    |   3 +-
 ArmPkg/Library/SemihostLib/SemihostPrivate.h  |  80 ++++-----
 .../ArmMmuStandaloneMmLib.inf                 |   4 +-
 ArmPlatformPkg/PrePeiCore/AArch64/Exception.S |  10 +-
 36 files changed, 416 insertions(+), 431 deletions(-)
 delete mode 100644 ArmPkg/Drivers/ArmGic/ArmGicSecLib.c

--
2.17.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#70620): https://edk2.groups.io/g/devel/message/70620
Mute This Topic: https://groups.io/mt/80000376/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-





More information about the edk2-devel-archive mailing list