[edk2-devel] [PATCH v3 17/18] UefiCpuPkg: CpuIo2Smm: Support of CpuIo driver under StandaloneMm
Kun Qin
kun.q at outlook.com
Fri Jan 22 04:40:48 UTC 2021
Hi Ray,
I was suggested not to rename the file for review easiness and git history concern during v2 patch. Thread here: Re: [PATCH v2 15/16] UefiCpuPkg: CpuIo2Smm: Support of CpuIo driver under StandaloneMm (groups.io)<https://edk2.groups.io/g/devel/message/69857>
Please let me know if you still recommend renaming the files. If so, would you suggest ```CpuIo2Smm.c/h --> CpuIo2Mm.c/h # remove the "S"``` to be a separate patch between gSmst change and adding Standalone MM instance?
Thanks in advance.
Regards,
Kun
From: Ni, Ray<mailto:ray.ni at intel.com>
Sent: Thursday, January 21, 2021 20:17
To: devel at edk2.groups.io<mailto:devel at edk2.groups.io>; kun.q at outlook.com<mailto:kun.q at outlook.com>
Cc: Dong, Eric<mailto:eric.dong at intel.com>; Laszlo Ersek<mailto:lersek at redhat.com>; Kumar, Rahul1<mailto:rahul1.kumar at intel.com>
Subject: RE: [edk2-devel] [PATCH v3 17/18] UefiCpuPkg: CpuIo2Smm: Support of CpuIo driver under StandaloneMm
>
> UefiCpuPkg/CpuIo2Smm/CpuIo2Smm.c | 9 ++----
> UefiCpuPkg/CpuIo2Smm/CpuIo2StandaloneMm.c | 32 ++++++++++++++++++++
> UefiCpuPkg/CpuIo2Smm/CpuIo2TraditionalMm.c | 32 ++++++++++++++++++++
> UefiCpuPkg/CpuIo2Smm/CpuIo2Smm.h | 12 ++++++++
> UefiCpuPkg/CpuIo2Smm/CpuIo2Smm.inf | 3 +-
> UefiCpuPkg/CpuIo2Smm/{CpuIo2Smm.inf => CpuIo2StandaloneMm.inf} | 18 +++++------
> UefiCpuPkg/UefiCpuPkg.dsc | 5 +++
How about do the file name change as below?
CpuIo2Smm.c/h --> CpuIo2Mm.c/h # remove the "S"
CpuIo2TraditionalMm.c -> CpuIo2Smm.c # Traditional MM equals to SMM. It also matches to CpuIo2Smm.inf.
CpuIo2StandaloneMm.c/inf # looks good to me.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#70665): https://edk2.groups.io/g/devel/message/70665
Mute This Topic: https://groups.io/mt/79688598/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/edk2-devel-archive/attachments/20210122/3d8a8abd/attachment.htm>
More information about the edk2-devel-archive
mailing list