[edk2-devel] [PATCH v1 1/1] BaseTools: Align include guards policy

[PierreGondois]

Please consider that currently, a vast majority of include guards have one or two leading underscore (such as __INCLUDE_FILE_H_) and are not respecting the edk2 coding standard. This patch will raise many Ecc errors in the CI. They should however not break it. Indeed, the Ecc errors should only reject a patch if it modifies a line having an Ecc error. This means that:
- merging this patch should not break all the CI jobs
- modifying a header file that has a bad include guard will make the CI prevent the patch from being merged
- any newly created header file will trigger the new check and ask for a correction
- any modification of a bad include guard will trigger the new check and ask for a correction

Regards,
Pierre


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#70725): https://edk2.groups.io/g/devel/message/70725
Mute This Topic: https://groups.io/mt/80106488/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/edk2-devel-archive/attachments/20210125/1db43733/attachment.htm>