[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [edk2-devel] [PATCH] MdeModulePkg/Bus/Pci/PciBusDxe: Increase the width of the data read during oprom shadow



Reviewed-by: Ray Ni <ray ni intel com>

> -----Original Message-----
> From: Laszlo Ersek <lersek redhat com>
> Sent: Friday, January 8, 2021 4:17 PM
> To: devel edk2 groups io; Venur, Sumana <sumana venur intel com>
> Cc: Wang, Jian J <jian j wang intel com>; Wu, Hao A <hao a wu intel com>; Ni, Ray <ray ni intel com>
> Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/Bus/Pci/PciBusDxe: Increase the width of the data read during oprom
> shadow
> 
> Adding PciBusDxe reviewers.
> 
> Thanks
> Laszlo
> 
> On 01/08/21 05:05, Sumana Venur wrote:
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2989
> >
> > Long times spent on shadowing oprom from graphics card to system memory. We are currently using 8 bit read cycles.
> > This needs to be wider, at least 32bit reads to reduce the time for oprom shadow
> >
> > Signed-off-by: Sumana Venur <sumana venur intel com>
> > ---
> >  MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c
> b/MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c
> > index c994ed5fe3..a981f93f43 100644
> > --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c
> > +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c
> > @@ -521,9 +521,9 @@ LoadOpRomImage (
> >      //
> >      PciDevice->PciRootBridgeIo->Mem.Read (
> >                                        PciDevice->PciRootBridgeIo,
> > -                                      EfiPciWidthUint8,
> > +                                      EfiPciWidthUint32,
> >                                        RomBar,
> > -                                      (UINT32) RomImageSize,
> > +                                      (UINT32) RomImageSize/sizeof(UINT32),
> >                                        Image
> >                                        );
> >      RomInMemory = Image;
> >



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#70091): https://edk2.groups.io/g/devel/message/70091
Mute This Topic: https://groups.io/mt/79498239/1813853
Group Owner: devel+owner edk2 groups io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive redhat com]
-=-=-=-=-=-=-=-=-=-=-=-




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]