Re: [EXTERNAL] 回复: [edk2-devel] 回复: [edk2][PATCH V3] MdePkg : Add IPMI Macro and Structure Defintions to resolve build errors

Tue Jul 6 17:41:53 UTC 2021

Yeah I can see the change. Thank you Liming for all your help.

-Manic

From: gaoliming <gaoliming at byosoft.com.cn>
Sent: Sunday, July 4, 2021 8:53 PM
To: devel at edk2.groups.io; gaoliming at byosoft.com.cn; lateefcs at gmail.com
Cc: Manickavasakam Karpagavinayagam <manickavasakamk at ami.com>; isaac.w.oram at intel.com; nathaniel.l.desimone at intel.com; Felix Polyudov <Felixp at ami.com>; Harikrishna Doppalapudi <Harikrishnad at ami.com>; Manish Jha <manishj at ami.com>; Zachary Bobroff <zacharyb at ami.com>
Subject: [EXTERNAL] 回复: [edk2-devel] 回复: [edk2][PATCH V3] MdePkg : Add IPMI Macro and Structure Defintions to resolve build errors

**CAUTION: The e-mail below is from an external source. Please exercise caution before opening attachments, clicking links, or following guidance.**
This patch in MdePkg has been merged at 55dee4947b20103fc48858b18307bd2b114dc145 on edk2 master.

Thanks
Liming
发件人: devel at edk2.groups.io<mailto:devel at edk2.groups.io> <devel at edk2.groups.io<mailto:devel at edk2.groups.io>> 代表 gaoliming
发送时间: 2021年6月30日 9:22
收件人: devel at edk2.groups.io<mailto:devel at edk2.groups.io>; gaoliming at byosoft.com.cn<mailto:gaoliming at byosoft.com.cn>; lateefcs at gmail.com<mailto:lateefcs at gmail.com>
抄送: 'manickavasakam karpagavinayagam' <manickavasakamk at ami.com<mailto:manickavasakamk at ami.com>>; isaac.w.oram at intel.com<mailto:isaac.w.oram at intel.com>; nathaniel.l.desimone at intel.com<mailto:nathaniel.l.desimone at intel.com>; Felixp at ami.com<mailto:Felixp at ami.com>; Harikrishnad at ami.com<mailto:Harikrishnad at ami.com>; manishj at ami.com<mailto:manishj at ami.com>; zacharyb at ami.com<mailto:zacharyb at ami.com>
主题: 回复: [edk2-devel] 回复: [edk2][PATCH V3] MdePkg : Add IPMI Macro and Structure Defintions to resolve build errors

If no other comment, I will create PR to merge this patch.

Thanks
Liming
发件人: devel at edk2.groups.io<mailto:devel at edk2.groups.io> <devel at edk2.groups.io<mailto:devel at edk2.groups.io>> 代表 gaoliming
发送时间: 2021年6月24日 8:54
收件人: devel at edk2.groups.io<mailto:devel at edk2.groups.io>; lateefcs at gmail.com<mailto:lateefcs at gmail.com>
抄送: 'manickavasakam karpagavinayagam' <manickavasakamk at ami.com<mailto:manickavasakamk at ami.com>>; isaac.w.oram at intel.com<mailto:isaac.w.oram at intel.com>; nathaniel.l.desimone at intel.com<mailto:nathaniel.l.desimone at intel.com>; Felixp at ami.com<mailto:Felixp at ami.com>; Harikrishnad at ami.com<mailto:Harikrishnad at ami.com>; manishj at ami.com<mailto:manishj at ami.com>; zacharyb at ami.com<mailto:zacharyb at ami.com>
主题: 回复: [edk2-devel] 回复: [edk2][PATCH V3] MdePkg : Add IPMI Macro and Structure Defintions to resolve build errors

AbduL:
 This is same to the definition of UINT8 CompletionCode without bitfield.

Thanks
Liming
发件人: devel at edk2.groups.io<mailto:devel at edk2.groups.io> <devel at edk2.groups.io<mailto:devel at edk2.groups.io>> 代表 AbduL Lateef
发送时间: 2021年6月23日 19:43
收件人: devel at edk2.groups.io<mailto:devel at edk2.groups.io>; gaoliming at byosoft.com.cn<mailto:gaoliming at byosoft.com.cn>
抄送: manickavasakam karpagavinayagam <manickavasakamk at ami.com<mailto:manickavasakamk at ami.com>>; isaac.w.oram at intel.com<mailto:isaac.w.oram at intel.com>; nathaniel.l.desimone at intel.com<mailto:nathaniel.l.desimone at intel.com>; Felixp at ami.com<mailto:Felixp at ami.com>; Harikrishnad at ami.com<mailto:Harikrishnad at ami.com>; manishj at ami.com<mailto:manishj at ami.com>; zacharyb at ami.com<mailto:zacharyb at ami.com>
主题: Re: [edk2-devel] 回复: [edk2][PATCH V3] MdePkg : Add IPMI Macro and Structure Defintions to resolve build errors

whats the use of bitfield:8 for UINT8 variable type?
+typedef struct {
+ UINT8 CompletionCode:8;
+} IPMI_SET_BOOT_OPTIONS_RESPONSE;

Thanks
AbduL

On Mon, Jun 21, 2021 at 7:19 AM gaoliming <gaoliming at byosoft.com.cn<mailto:gaoliming at byosoft.com.cn>> wrote:
Thanks for you update.

Reviewed-by: Liming Gao <gaoliming at byosoft.com.cn<mailto:gaoliming at byosoft.com.cn>>

Thanks
Liming
> -----邮件原件-----
> 发件人: manickavasakam karpagavinayagam <manickavasakamk at ami.com<mailto:manickavasakamk at ami.com>>
> 发送时间: 2021年6月18日 23:38
> 收件人: devel at edk2.groups.io<mailto:devel at edk2.groups.io>
> 抄送: isaac.w.oram at intel.com<mailto:isaac.w.oram at intel.com>; nathaniel.l.desimone at intel.com<mailto:nathaniel.l.desimone at intel.com>;
> Felixp at ami.com<mailto:Felixp at ami.com>; Harikrishnad at ami.com<mailto:Harikrishnad at ami.com>; manishj at ami.com<mailto:manishj at ami.com>;
> zacharyb at ami.com<mailto:zacharyb at ami.com>; manickavasakamk at ami.com<mailto:manickavasakamk at ami.com>;
> gaoliming at byosoft.com.cn<mailto:gaoliming at byosoft.com.cn>
> 主题: [edk2][PATCH V3] MdePkg : Add IPMI Macro and Structure Defintions
> to resolve build errors
>
> Build error reported for missing structures
> IPMI_SET_BOOT_OPTIONS_RESPONSE,
> EFI_IPMI_MSG_GET_BMC_EXEC_RSP and
> macros EFI_FIRMWARE_GET_BMC_EXECUTION_CONTEXT
> EFI_FIRMWARE_BMC_IN_FULL_RUNTIME/EFI_FIRMWARE_BMC_IN_FORCE
> D_UPDATE_MODE
> when using
> edk2-platforms\Features\Intel\OutOfBandManagement\IpmiFeaturePkg
>
> MdePkg : Rename IPMI Macro and Structure Defintions
>
> Rename the EFI_IPMI_MSG_GET_BMC_EXEC_RSPB,
> EFI_FIRMWARE_GET_BMC_EXECUTION_CONTEXT
> EFI_FIRMWARE_BMC_IN_FORCED_UPDATE_MODE to
> IPMI_MSG_GET_BMC_EXEC_RSPB,IPMI_GET_BMC_EXECUTION_CONTEXT
> IPMI_BMC_IN_FORCED_UPDATE_MODE
>
> Notes:
> V1 :
> Rename the EFI_IPMI_MSG_GET_BMC_EXEC_RSPB,
> EFI_FIRMWARE_GET_BMC_EXECUTION_CONTEXT
> EFI_FIRMWARE_BMC_IN_FORCED_UPDATE_MODE to
> IPMI_MSG_GET_BMC_EXEC_RSPB,IPMI_GET_BMC_EXECUTION_CONTEXT
> IPMI_BMC_IN_FORCED_UPDATE_MODE
>
> V2:
>
> Remove 0001-MdePkg-Add-IPMI-Macro-and-Structure-Defintions-to-re.patch
>
> V3:
>
> Add Signed-off-by information
>
> Signed-off-by: Manickavasakam Karpagavinayagam
> <manickavasakamk at ami.com<mailto:manickavasakamk at ami.com>>
> ---
>  .../IndustryStandard/IpmiNetFnChassis.h        |  4 ++++
>  .../IndustryStandard/IpmiNetFnFirmware.h       | 18
> ++++++++++++++++++
>  2 files changed, 22 insertions(+)
>
> diff --git a/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h
> b/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h
> index 79db55523d..d7cdd3a865 100644
> --- a/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h
> +++ b/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h
> @@ -186,6 +186,10 @@ typedef struct {
>    UINT8                                  ParameterData[0];
>
>  } IPMI_SET_BOOT_OPTIONS_REQUEST;
>
>
>
> +typedef struct {
>
> +  UINT8   CompletionCode:8;
>
> +} IPMI_SET_BOOT_OPTIONS_RESPONSE;
>
> +
>
>  //
>
>  //  Definitions for Get System Boot options command
>
>  //
>
> diff --git a/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h
> b/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h
> index 2d892dbd5a..c4cbe2349b 100644
> --- a/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h
> +++ b/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h
> @@ -17,4 +17,22 @@
>  // All Firmware commands and their structure definitions to follow here
>
>  //
>
>
>
> +//
----------------------------------------------------------------------------
------------
>
> +//    Definitions for Get BMC Execution Context
>
> +//
----------------------------------------------------------------------------
------------
>
> +#define IPMI_GET_BMC_EXECUTION_CONTEXT  0x23
>
> +
>
> +//
>
> +//  Constants and Structure definitions for "Get Device ID" command to
> follow here
>
> +//
>
> +typedef struct {
>
> +  UINT8   CurrentExecutionContext;
>
> +  UINT8   PartitionPointer;
>
> +} IPMI_MSG_GET_BMC_EXEC_RSP;
>
> +
>
> +//
>
> +// Current Execution Context responses
>
> +//
>
> +#define IPMI_BMC_IN_FORCED_UPDATE_MODE  0x11
>
> +
>
>  #endif
>
> --
> 2.25.0.windows.1
>
>
> Please consider the environment before printing this email.
>
> The information contained in this message may be confidential and
> proprietary to American Megatrends (AMI).  This communication is intended
> to be read only by the individual or entity to whom it is addressed or by
their
> designee. If the reader of this message is not the intended recipient, you
are
> on notice that any distribution of this message, in any form, is strictly
> prohibited.  Please promptly notify the sender by reply e-mail or by
> telephone at 770-246-8600, and then delete or destroy all copies of the
> transmission.

--
Thanks and Regards
Abdul Lateef Attar
Bangalore

-The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#77531): https://edk2.groups.io/g/devel/message/77531
Mute This Topic: https://groups.io/mt/84026242/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/edk2-devel-archive/attachments/20210706/f6b54fb5/attachment.htm>