[edk2-devel] 回复: [PATCH v2 0/4] Allow EccCheck to run on other repositories

[gaoliming]

This version is good to me. Reviewed-by: Liming Gao
<gaoliming at byosoft.com.cn>

Thanks
Liming
> -----邮件原件-----
> 发件人: Pierre.Gondois at arm.com <Pierre.Gondois at arm.com>
> 发送时间: 2021年7月7日 4:56
> 收件人: devel at edk2.groups.io; Sean Brogan <sean.brogan at microsoft.com>;
> Bret Barkelew <Bret.Barkelew at microsoft.com>; Michael D Kinney
> <michael.d.kinney at intel.com>; Liming Gao <gaoliming at byosoft.com.cn>;
> Sami Mujawar <sami.mujawar at arm.com>
> 主题: [PATCH v2 0/4] Allow EccCheck to run on other repositories
> 
> From: Pierre Gondois <Pierre.Gondois at arm.com>
> 
> EccCheck currently makes some assumptions on its working
> environment that prevent it from running it in other repositories.
> For instance, the workspace is assumed to be pointing to the edk2
> repository path, which can be wrong.
> This patch-set aims to allow the EccCheck tool to run on the
> edk2-platforms repository, with edk2 being a submodule of
> edk2-platforms.
> 
> The changes can be seen at:
> https://github.com/PierreARM/edk2/commits/1628_Ecc_environment_paths
> _update_v2
> 
> v2:
>  - Use ';' path separator for Windows host [Liming]
> 
> Pierre Gondois (4):
>   .pytool/EccCheck: Locate BaseTools dir with EDK_TOOLS_PATH
>   .pytool/EccCheck: Rename edk2_path as workspace_path
>   .pytool/EccCheck: Check ecc_csv exists
>   .pytool/EccCheck: Set PACKAGES_PATH env var in Ecc
> 
>  .pytool/Plugin/EccCheck/EccCheck.py | 46 +++++++++++++++--------------
>  1 file changed, 24 insertions(+), 22 deletions(-)
> 
> --
> 2.17.1





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#77543): https://edk2.groups.io/g/devel/message/77543
Mute This Topic: https://groups.io/mt/84036372/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-