[edk2-devel] [edk2-platforms PATCH v2 2/2] Revert "Platform/RaspberryPi: Setup option for disabling Fast Boot"
Samer El-Haj-Mahmoud
samer.el-haj-mahmoud at arm.com
Thu Jul 8 18:36:43 UTC 2021
Reviewed-By: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud at arm.com>
> -----Original Message-----
> From: Grzegorz Bernacki <gjb at semihalf.com>
> Sent: Tuesday, July 6, 2021 6:45 AM
> To: devel at edk2.groups.io
> Cc: leif at nuviainc.com; ardb+tianocore at kernel.org; Samer El-Haj-Mahmoud
> <Samer.El-Haj-Mahmoud at arm.com>; Sunny Wang
> <Sunny.Wang at arm.com>; mw at semihalf.com; upstream at semihalf.com;
> pete at akeo.ie; jian.j.wang at intel.com; hao.a.wu at intel.com;
> dandan.bi at intel.com; eric.dong at intel.com; Grzegorz Bernacki
> <gjb at semihalf.com>; Sunny Wang <Sunny.Wang at arm.com>
> Subject: [edk2-platforms PATCH v2 2/2] Revert "Platform/RaspberryPi: Setup
> option for disabling Fast Boot"
>
> This reverts commit efdc159ef7c9f15581a0f63d755a1530ff475156.
>
> This commit is not longer required as Boot Discovery Policy has
> been implemented for RPi.
>
> Signed-off-by: Grzegorz Bernacki <gjb at semihalf.com>
> Reviewed-by: Sunny Wang <sunny.wang at arm.com>
> ---
> Platform/RaspberryPi/RaspberryPi.dec | 2 --
> Platform/RaspberryPi/RPi3/RPi3.dsc | 9 +--------
> Platform/RaspberryPi/RPi4/RPi4.dsc | 9 +--------
> Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.inf | 3 +-
> -
>
> Platform/RaspberryPi/Library/PlatformBootManagerLib/PlatformBootManag
> erLib.inf | 1 -
> Platform/RaspberryPi/Include/ConfigVars.h | 12 +--------
> ---
> Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.vfr | 16
> +---------------
> Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c | 11 +-
> ---------
> Platform/RaspberryPi/Library/PlatformBootManagerLib/PlatformBm.c
> | 15 ++-------------
> Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.uni | 10
> +---------
> 10 files changed, 9 insertions(+), 79 deletions(-)
>
> diff --git a/Platform/RaspberryPi/RaspberryPi.dec
> b/Platform/RaspberryPi/RaspberryPi.dec
> index f1dd8ac0ed..2ca25ff9e6 100644
> --- a/Platform/RaspberryPi/RaspberryPi.dec
> +++ b/Platform/RaspberryPi/RaspberryPi.dec
> @@ -2,7 +2,6 @@
> #
> # Copyright (c) 2016, Linaro, Ltd. All rights reserved.
> # Copyright (c) 2017-2018, Andrei Warkentin
> <andrey.warkentin at gmail.com>
> -# Copyright (c) 2021, ARM Limited. All rights reserved.
> #
> # SPDX-License-Identifier: BSD-2-Clause-Patent
> #
> @@ -71,5 +70,4 @@
> gRaspberryPiTokenSpaceGuid.PcdFanTemp|0|UINT32|0x0000001D
>
> gRaspberryPiTokenSpaceGuid.PcdPlatformResetDelay|0|UINT32|0x0000001
> E
> gRaspberryPiTokenSpaceGuid.PcdMmcEnableDma|0|UINT32|0x0000001F
> - gRaspberryPiTokenSpaceGuid.PcdBootPolicy|0|UINT32|0x00000020
> gRaspberryPiTokenSpaceGuid.PcdUartInUse|1|UINT32|0x00000021
> diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc
> b/Platform/RaspberryPi/RPi3/RPi3.dsc
> index 53825bcf62..b6e3372c61 100644
> --- a/Platform/RaspberryPi/RPi3/RPi3.dsc
> +++ b/Platform/RaspberryPi/RPi3/RPi3.dsc
> @@ -1,6 +1,6 @@
> # @file
> #
> -# Copyright (c) 2011 - 2021, ARM Limited. All rights reserved.
> +# Copyright (c) 2011 - 2020, ARM Limited. All rights reserved.
> # Copyright (c) 2014, Linaro Limited. All rights reserved.
> # Copyright (c) 2015 - 2021, Intel Corporation. All rights reserved.
> # Copyright (c) 2017 - 2018, Andrei Warkentin
> <andrey.warkentin at gmail.com>
> @@ -512,13 +512,6 @@
>
> gRaspberryPiTokenSpaceGuid.PcdFanOnGpio|L"FanOnGpio"|gConfigDxeFor
> mSetGuid|0x0|0
>
> gRaspberryPiTokenSpaceGuid.PcdFanTemp|L"FanTemp"|gConfigDxeFormSet
> Guid|0x0|0
>
> - #
> - # Boot Policy
> - # 0 - Fast Boot
> - # 1 - Full Discovery (Connect All)
> - #
> -
> gRaspberryPiTokenSpaceGuid.PcdBootPolicy|L"BootPolicy"|gConfigDxeForm
> SetGuid|0x0|1
> -
> #
> # Reset-related.
> #
> diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc
> b/Platform/RaspberryPi/RPi4/RPi4.dsc
> index 8b9beac64a..07f36e7f1b 100644
> --- a/Platform/RaspberryPi/RPi4/RPi4.dsc
> +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc
> @@ -1,6 +1,6 @@
> # @file
> #
> -# Copyright (c) 2011 - 2021, ARM Limited. All rights reserved.
> +# Copyright (c) 2011 - 2020, ARM Limited. All rights reserved.
> # Copyright (c) 2017 - 2018, Andrei Warkentin
> <andrey.warkentin at gmail.com>
> # Copyright (c) 2015 - 2021, Intel Corporation. All rights reserved.
> # Copyright (c) 2014, Linaro Limited. All rights reserved.
> @@ -528,13 +528,6 @@
>
> gRaspberryPiTokenSpaceGuid.PcdFanOnGpio|L"FanOnGpio"|gConfigDxeFor
> mSetGuid|0x0|0
>
> gRaspberryPiTokenSpaceGuid.PcdFanTemp|L"FanTemp"|gConfigDxeFormSet
> Guid|0x0|60
>
> - #
> - # Boot Policy
> - # 0 - Fast Boot
> - # 1 - Full Discovery (Connect All)
> - #
> -
> gRaspberryPiTokenSpaceGuid.PcdBootPolicy|L"BootPolicy"|gConfigDxeForm
> SetGuid|0x0|1
> -
> #
> # Reset-related.
> #
> diff --git a/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.inf
> b/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.inf
> index 597e1b4205..4bb2d08550 100644
> --- a/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.inf
> +++ b/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.inf
> @@ -2,7 +2,7 @@
> #
> # Component description file for the RasbperryPi DXE platform config
> driver.
> #
> -# Copyright (c) 2019 - 2021, ARM Limited. All rights reserved.
> +# Copyright (c) 2019 - 2020, ARM Limited. All rights reserved.
> # Copyright (c) 2018 - 2020, Andrei Warkentin
> <andrey.warkentin at gmail.com>
> #
> # SPDX-License-Identifier: BSD-2-Clause-Patent
> @@ -93,7 +93,6 @@
> gRaspberryPiTokenSpaceGuid.PcdRamLimitTo3GB
> gRaspberryPiTokenSpaceGuid.PcdFanOnGpio
> gRaspberryPiTokenSpaceGuid.PcdFanTemp
> - gRaspberryPiTokenSpaceGuid.PcdBootPolicy
> gRaspberryPiTokenSpaceGuid.PcdUartInUse
>
> [Depex]
> diff --git
> a/Platform/RaspberryPi/Library/PlatformBootManagerLib/PlatformBootMan
> agerLib.inf
> b/Platform/RaspberryPi/Library/PlatformBootManagerLib/PlatformBootMan
> agerLib.inf
> index 4ef2f791ae..c047364b28 100644
> ---
> a/Platform/RaspberryPi/Library/PlatformBootManagerLib/PlatformBootMan
> agerLib.inf
> +++
> b/Platform/RaspberryPi/Library/PlatformBootManagerLib/PlatformBootMan
> agerLib.inf
> @@ -64,7 +64,6 @@
> gEfiMdeModulePkgTokenSpaceGuid.PcdBootDiscoveryPolicy
> gEfiMdePkgTokenSpaceGuid.PcdPlatformBootTimeOut
> gRaspberryPiTokenSpaceGuid.PcdSdIsArasan
> - gRaspberryPiTokenSpaceGuid.PcdBootPolicy
>
> [Guids]
> gBootDiscoveryPolicyMgrFormsetGuid
> diff --git a/Platform/RaspberryPi/Include/ConfigVars.h
> b/Platform/RaspberryPi/Include/ConfigVars.h
> index 9ef62b7a6e..142317985a 100644
> --- a/Platform/RaspberryPi/Include/ConfigVars.h
> +++ b/Platform/RaspberryPi/Include/ConfigVars.h
> @@ -1,7 +1,7 @@
> /** @file
> *
> * Copyright (c) 2020, Andrei Warkentin <andrey.warkentin at gmail.com>
> - * Copyright (c) 2020 - 2021, ARM Limited. All rights reserved.
> + * Copyright (c) 2020, ARM Limited. All rights reserved.
> *
> * SPDX-License-Identifier: BSD-2-Clause-Patent
> *
> @@ -143,14 +143,4 @@ typedef struct {
> UINT32 EnableDma;
> } MMC_EMMC_DMA_VARSTORE_DATA;
>
> -#define FAST_BOOT 0
> -#define FULL_DISCOVERY 1
> -typedef struct {
> - /*
> - * 0 - Fast Boot
> - * 1 - Full Discovery (Connect All)
> - */
> - UINT32 BootPolicy;
> -} BOOT_POLICY_VARSTORE_DATA;
> -
> #endif /* CONFIG_VARS_H */
> diff --git a/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.vfr
> b/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.vfr
> index 759db6212f..fa34eab809 100644
> --- a/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.vfr
> +++ b/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.vfr
> @@ -1,7 +1,7 @@
> /** @file
> *
> * Copyright (c) 2018 Andrei Warkentin <andrey.warkentin at gmail.com>
> - * Copyright (c) 2020 - 2021, ARM Limited. All rights reserved.
> + * Copyright (c) 2020, ARM Limited. All rights reserved.
> *
> * SPDX-License-Identifier: BSD-2-Clause-Patent
> *
> @@ -116,11 +116,6 @@ formset
> name = DisplayEnableSShot,
> guid = CONFIGDXE_FORM_SET_GUID;
>
> - efivarstore BOOT_POLICY_VARSTORE_DATA,
> - attribute = EFI_VARIABLE_BOOTSERVICE_ACCESS |
> EFI_VARIABLE_RUNTIME_ACCESS | EFI_VARIABLE_NON_VOLATILE,
> - name = BootPolicy,
> - guid = CONFIGDXE_FORM_SET_GUID;
> -
> form formid = 1,
> title = STRING_TOKEN(STR_FORM_SET_TITLE);
> subtitle text = STRING_TOKEN(STR_NULL_STRING);
> @@ -195,14 +190,6 @@ formset
> option text = STRING_TOKEN(STR_ADVANCED_SYSTAB_DT), value =
> SYSTEM_TABLE_MODE_DT, flags = DEFAULT;
> endoneof;
>
> - oneof varid = BootPolicy.BootPolicy,
> - prompt = STRING_TOKEN(STR_BOOT_POLICY_PROMPT),
> - help = STRING_TOKEN(STR_BOOT_POLICY_HELP),
> - flags = NUMERIC_SIZE_4 | INTERACTIVE | RESET_REQUIRED,
> - option text = STRING_TOKEN(STR_FAST_BOOT), value = FAST_BOOT ,
> flags = 0;
> - option text = STRING_TOKEN(STR_FULL_DISCOVERY), value =
> FULL_DISCOVERY, flags = DEFAULT;
> - endoneof;
> -
> #if (RPI_MODEL == 4)
> grayoutif NOT ideqval SystemTableMode.Mode ==
> SYSTEM_TABLE_MODE_ACPI;
> oneof varid = FanOnGpio.Enabled,
> @@ -233,7 +220,6 @@ formset
> minsize = 0,
> maxsize = ASSET_TAG_STR_MAX_LEN,
> endstring;
> -
> endform;
>
> form formid = 0x1003,
> diff --git a/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c
> b/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c
> index cf9880bd20..9e78cb47ad 100644
> --- a/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c
> +++ b/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c
> @@ -1,6 +1,6 @@
> /** @file
> *
> - * Copyright (c) 2019 - 2021, ARM Limited. All rights reserved.
> + * Copyright (c) 2019 - 2020, ARM Limited. All rights reserved.
> * Copyright (c) 2018 - 2020, Andrei Warkentin
> <andrey.warkentin at gmail.com>
> *
> * SPDX-License-Identifier: BSD-2-Clause-Patent
> @@ -286,15 +286,6 @@ SetupVariables (
> );
> }
>
> - Size = sizeof (UINT32);
> - Status = gRT->GetVariable (L"BootPolicy",
> - &gConfigDxeFormSetGuid,
> - NULL, &Size, &Var32);
> - if (EFI_ERROR (Status)) {
> - Status = PcdSet32S (PcdBootPolicy, PcdGet32 (PcdBootPolicy));
> - ASSERT_EFI_ERROR (Status);
> - }
> -
> Size = sizeof (UINT32);
> Status = gRT->GetVariable (L"SdIsArasan",
> &gConfigDxeFormSetGuid,
> diff --git
> a/Platform/RaspberryPi/Library/PlatformBootManagerLib/PlatformBm.c
> b/Platform/RaspberryPi/Library/PlatformBootManagerLib/PlatformBm.c
> index 4bfa906921..b5b485f3e8 100644
> --- a/Platform/RaspberryPi/Library/PlatformBootManagerLib/PlatformBm.c
> +++ b/Platform/RaspberryPi/Library/PlatformBootManagerLib/PlatformBm.c
> @@ -4,7 +4,7 @@
> * Copyright (c) 2017-2018, Andrei Warkentin
> <andrey.warkentin at gmail.com>
> * Copyright (c) 2016, Linaro Ltd. All rights reserved.
> * Copyright (c) 2015-2016, Red Hat, Inc.
> - * Copyright (c) 2014-2021, ARM Ltd. All rights reserved.
> + * Copyright (c) 2014-2020, ARM Ltd. All rights reserved.
> * Copyright (c) 2004-2016, Intel Corporation. All rights reserved.
> * Copyright (c) 2021, Semihalf All rights reserved.
> *
> @@ -28,11 +28,10 @@
> #include <Guid/BootDiscoveryPolicy.h>
> #include <Guid/EventGroup.h>
> #include <Guid/TtyTerm.h>
> -#include <ConfigVars.h>
>
> #include "PlatformBm.h"
>
> -#define BOOT_PROMPT L"ESC (setup), F1 (shell), ENTER (boot)\n"
> +#define BOOT_PROMPT L"ESC (setup), F1 (shell), ENTER (boot)"
>
> #define DP_NODE_LEN(Type) { (UINT8)sizeof (Type), (UINT8)(sizeof (Type)
> >> 8) }
>
> @@ -719,16 +718,6 @@ PlatformBootManagerAfterConsole (
> Print (BOOT_PROMPT);
> }
>
> - //
> - // Connect the rest of the devices if the boot polcy is set to Full discovery
> - //
> - if (PcdGet32 (PcdBootPolicy) == FULL_DISCOVERY) {
> - DEBUG ((DEBUG_INFO, "Boot Policy is Full Discovery. Connect all
> devices\n"));
> - EfiBootManagerConnectAll ();
> - } else if (PcdGet32 (PcdBootPolicy) == FAST_BOOT) {
> - DEBUG ((DEBUG_INFO, "Boot Policy is Fast Boot. Skip connecting all
> devices\n"));
> - }
> -
> Status = BootDiscoveryPolicyHandler ();
> if (EFI_ERROR(Status)) {
> DEBUG ((DEBUG_INFO, "Error applying Boot Discovery Policy:%r\n",
> Status));
> diff --git a/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.uni
> b/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.uni
> index 81761d64bb..466fa852cb 100644
> --- a/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.uni
> +++ b/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.uni
> @@ -1,7 +1,7 @@
> /** @file
> *
> * Copyright (c) 2018, Andrei Warkentin <andrey.warkentin at gmail.com>
> - * Copyright (c) 2020 - 2021, ARM Limited. All rights reserved.
> + * Copyright (c) 2020, ARM Limited. All rights reserved.
> *
> * SPDX-License-Identifier: BSD-2-Clause-Patent
> *
> @@ -60,14 +60,6 @@
> #string STR_ADVANCED_ASSET_TAG_PROMPT #language en-US "Asset Tag"
> #string STR_ADVANCED_ASSET_TAG_HELP #language en-US "Set the system
> Asset Tag"
>
> -#string STR_BOOT_POLICY_PROMPT #language en-US "Boot Policy"
> -#string STR_BOOT_POLICY_HELP #language en-US "When Fast Boot is
> selected, only required devices will be discovered for reducing "
> - "the boot time. "
> - "When Full Discovery is selected, all the
> devices will be discovered for some "
> - "scenarios such as system deployment and
> diagnostic tests."
> -#string STR_FAST_BOOT #language en-US "Fast Boot"
> -#string STR_FULL_DISCOVERY #language en-US "Full Discovery"
> -
> /*
> * MMC/SD configuration.
> */
> --
> 2.25.1
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#77610): https://edk2.groups.io/g/devel/message/77610
Mute This Topic: https://groups.io/mt/84017529/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-
More information about the edk2-devel-archive
mailing list