[edk2-devel] [PATCH V2 2/4] Silicon/NXP: Add support of SVR handling for LS1046A SoC

[Sunny Wang]

Looks good.
Just have some comments mentioned Patch 0/4 about moving/renaming file/folder for synchronizing with NXP LSDK opensource https://source.codeaurora.org/external/qoriq/qoriq-components/edk2-platforms.

Best Regards,
Sunny Wang

-----Original Message-----
From: Vikas Singh <vikas.singh at puresoftware.com>
Sent: Friday, June 18, 2021 11:28 PM
To: devel at edk2.groups.io
Cc: Sami Mujawar <Sami.Mujawar at arm.com>; leif at nuviainc.com; Meenakshi Aggarwal (meenakshi.aggarwal at nxp.com) <meenakshi.aggarwal at nxp.com>; Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud at arm.com>; V Sethi (v.sethi at nxp.com) <v.sethi at nxp.com>; arokia.samy <arokia.samy at puresoftware.com>; kuldip.dwivedi at puresoftware.com; Ard Biesheuvel <Ard.Biesheuvel at arm.com>; vikas.singh at nxp.com; Sunny Wang <Sunny.Wang at arm.com>
Subject: [PATCH V2 2/4] Silicon/NXP: Add support of SVR handling for LS1046A SoC

This patch adds a generic method to get Silicon Version Register (SVR)
on LS1046A SoC. This method will be generic for all platfroms based
on LS1046A SoC, like - LS1046AFRWY, LS1046ARDB.

Signed-off-by: Vikas Singh <vikas.singh at puresoftware.com>
---
 Silicon/NXP/LS1046A/Library/SocLib/SocLib.c | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/Silicon/NXP/LS1046A/Library/SocLib/SocLib.c b/Silicon/NXP/LS1046A/Library/SocLib/SocLib.c
index 8fa6a7dd00..003f5bd82f 100644
--- a/Silicon/NXP/LS1046A/Library/SocLib/SocLib.c
+++ b/Silicon/NXP/LS1046A/Library/SocLib/SocLib.c
@@ -2,6 +2,7 @@
   SoC specific Library containg functions to initialize various SoC components



   Copyright 2017-2020 NXP

+  Copyright 2021 Puresoftware Ltd



   SPDX-License-Identifier: BSD-2-Clause-Patent



@@ -64,6 +65,21 @@ SocGetClock (
   return ReturnValue;

 }



+/**

+  Function to get SoC's System Version Register(SVR)

+ **/

+UINT32

+SocGetSvr (

+  VOID

+  )

+{

+  LS1046A_DEVICE_CONFIG  *Dcfg;

+

+  Dcfg = (LS1046A_DEVICE_CONFIG  *)LS1046A_DCFG_ADDRESS;

+

+  return DcfgRead32 ((UINTN)&Dcfg->Svr);

+}

+

 /**

    Function to select pins depending upon pcd using supplemental

    configuration unit(SCFG) extended RCW controlled pinmux control

--
2.25.1

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#77689): https://edk2.groups.io/g/devel/message/77689
Mute This Topic: https://groups.io/mt/83630883/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-