[edk2-devel] [PATCH edk2-platforms v1 1/1] Platform/ARM: FVP: Fix variable usage in GetArmNameSpaceObject()

[Sami Mujawar]

Pushed as 8cb431b46a08..564a6a340892

Thanks.

Regards,

Sami Mujawar

On 13/07/2021, 18:05, "Sami Mujawar" <sami.mujawar at arm.com> wrote:

    Hi Joey,

    Thank you for this patch. This patch looks good to me.

    Reviewed-by: Sami Mujawar <sami.mujawar at arm.com>

    Regards,

    Sami Mujawar


    On 01/07/2021 01:24 PM, Joey Gouly wrote:
    > Building with Clang showed that `RootComplexCount` and
    > `DeviceIdMappingArrayCount` were unused. Use the
    > variables where they were intended to be used.
    >
    > Signed-off-by: Joey Gouly <joey.gouly at arm.com>
    > ---
    >
    > The changes can be seen at https://github.com/jgouly/edk2-platforms/tree/1766_vexpress_count_v1
    >
    >   Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c | 4 ++--
    >   1 file changed, 2 insertions(+), 2 deletions(-)
    >
    > diff --git a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
    > index e99fbb654f5109321e32905af3763233dffdbc3e..776dec999eb1ef47910835987fa4dae1b69c52fd 100644
    > --- a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
    > +++ b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
    > @@ -924,7 +924,7 @@ GetArmNameSpaceObject (
    >                    CmObjectId,
    >                    &PlatformRepo->RootComplexInfo,
    >                    sizeof (PlatformRepo->RootComplexInfo),
    > -                 1,
    > +                 RootComplexCount,
    >                    CmObject
    >                    );
    >         break;
    > @@ -935,7 +935,7 @@ GetArmNameSpaceObject (
    >                    CmObjectId,
    >                    PlatformRepo->DeviceIdMapping,
    >                    sizeof (PlatformRepo->DeviceIdMapping),
    > -                 ARRAY_SIZE (PlatformRepo->DeviceIdMapping),
    > +                 DeviceIdMappingArrayCount,
    >                    Token,
    >                    GetDeviceIdMappingArray,
    >                    CmObject




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#77793): https://edk2.groups.io/g/devel/message/77793
Mute This Topic: https://groups.io/mt/83914555/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-