[edk2-devel] [PATCH v2 1/1] ArmVirtPkg: Remove meaningless comment

[Sami Mujawar]

Hi Philippe,

Thank you for this patch.

Reviewed-by: Sami Mujawar <sami.mujawar at arm.com>

Regards,

Sami Mujawar

On 21/07/2021, 09:19, "Philippe Mathieu-Daudé" <philmd at redhat.com> wrote:

    From: Philippe Mathieu-Daude <philmd at redhat.com>

    The "Shell Embedded Boot Loader" description (added in
    commit 6f5872b1f401) does not add any value, remove it.

    Cc: Laszlo Ersek <lersek at redhat.com>
    Cc: Ard Biesheuvel <ardb+tianocore at kernel.org>
    Cc: Leif Lindholm <leif at nuviainc.com>
    Cc: Sami Mujawar <sami.mujawar at arm.com>
    Cc: Julien Grall <julien at xen.org>
    Suggested-by: Laszlo Ersek <lersek at redhat.com>
    Signed-off-by: Philippe Mathieu-Daude <philmd at redhat.com>
    ---
     ArmVirtPkg/ArmVirt.dsc.inc           | 3 ---
     ArmVirtPkg/ArmVirtKvmTool.fdf        | 3 ---
     ArmVirtPkg/ArmVirtXen.fdf            | 3 ---
     ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc | 3 ---
     4 files changed, 12 deletions(-)

    diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc
    index d9abadbe708c..619b5f0b44c0 100644
    --- a/ArmVirtPkg/ArmVirt.dsc.inc
    +++ b/ArmVirtPkg/ArmVirt.dsc.inc
    @@ -375,9 +375,6 @@ [Components.common]
       #
       MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf

    -  #
    -  # UEFI application (Shell Embedded Boot Loader)
    -  #
       ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf {
         <PcdsFixedAtBuild>
           gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE
    diff --git a/ArmVirtPkg/ArmVirtKvmTool.fdf b/ArmVirtPkg/ArmVirtKvmTool.fdf
    index 076155199905..152453dc4bb3 100644
    --- a/ArmVirtPkg/ArmVirtKvmTool.fdf
    +++ b/ArmVirtPkg/ArmVirtKvmTool.fdf
    @@ -173,9 +173,6 @@ [FV.FvMain]
       INF OvmfPkg/VirtioScsiDxe/VirtioScsi.inf
       INF OvmfPkg/VirtioRngDxe/VirtioRng.inf

    -  #
    -  # UEFI application (Shell Embedded Boot Loader)
    -  #
       INF ShellPkg/Application/Shell/Shell.inf
       INF ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf

    diff --git a/ArmVirtPkg/ArmVirtXen.fdf b/ArmVirtPkg/ArmVirtXen.fdf
    index 8fbbc2313aff..9597465cf58a 100644
    --- a/ArmVirtPkg/ArmVirtXen.fdf
    +++ b/ArmVirtPkg/ArmVirtXen.fdf
    @@ -177,9 +177,6 @@ [FV.FvMain]
       INF MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf
       INF MdeModulePkg/Universal/Disk/UdfDxe/UdfDxe.inf

    -  #
    -  # UEFI application (Shell Embedded Boot Loader)
    -  #
       INF ShellPkg/Application/Shell/Shell.inf
       INF ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf
       INF ShellPkg/DynamicCommand/HttpDynamicCommand/HttpDynamicCommand.inf
    diff --git a/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc b/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc
    index 5b1d10057545..26f13f6a2115 100644
    --- a/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc
    +++ b/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc
    @@ -99,9 +99,6 @@ [FV.FvMain]
       INF OvmfPkg/VirtioScsiDxe/VirtioScsi.inf
       INF OvmfPkg/VirtioRngDxe/VirtioRng.inf

    -  #
    -  # UEFI application (Shell Embedded Boot Loader)
    -  #
       INF ShellPkg/Application/Shell/Shell.inf
       INF ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf
       INF ShellPkg/DynamicCommand/HttpDynamicCommand/HttpDynamicCommand.inf
    -- 
    2.31.1




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#78015): https://edk2.groups.io/g/devel/message/78015
Mute This Topic: https://groups.io/mt/84352180/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-