[edk2-devel] ArmVirt and Self-Updating Code

Thu Jul 22 14:54:39 UTC 2021

Expanding audience to the full dev list…
See below…

- Bret

From: Thomas Abraham<mailto:thomas.abraham at arm.com>
Sent: Wednesday, July 7, 2021 11:07 PM
To: Bret Barkelew<mailto:Bret.Barkelew at microsoft.com>; Ard Biesheuvel (TianoCore)<mailto:ardb+tianocore at kernel.org>; Lindholm, Leif<mailto:leif at nuviainc.com>; Laszlo Ersek<mailto:lersek at redhat.com>; Marvin Häuser<mailto:mhaeuser at posteo.de>; Sami Mujawar<mailto:sami.mujawar at arm.com>
Cc: nd<mailto:nd at arm.com>
Subject: [EXTERNAL] RE: ArmVirt and Self-Updating Code

+ Sami

From: Bret Barkelew <Bret.Barkelew at microsoft.com>
Sent: Thursday, July 8, 2021 11:05 AM
To: Thomas Abraham <thomas.abraham at arm.com>; Ard Biesheuvel (TianoCore) <ardb+tianocore at kernel.org>; Lindholm, Leif <leif at nuviainc.com>; Laszlo Ersek <lersek at redhat.com>; Marvin Häuser <mhaeuser at posteo.de>
Subject: ArmVirt and Self-Updating Code

All,

Marvin asked me a question on the UEFI Talkbox Discord that’s a little beyond my ken…

“There is self-relocating code in ArmVirtPkg:
https://github.com/tianocore/edk2/blob/17143c4837393d42c484b42d1789b85b2cff1aaf/ArmVirtPkg/PrePi/PrePi.c#L133-L165<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftianocore%2Fedk2%2Fblob%2F17143c4837393d42c484b42d1789b85b2cff1aaf%2FArmVirtPkg%2FPrePi%2FPrePi.c%23L133-L165&data=04%7C01%7CBret.Barkelew%40microsoft.com%7C7f8b266a81d44c853f6108d941d6a804%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637613212486760659%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=Qe54pIgdrQiP%2Bb9WNOhSRqbWWsJ8FG4ukaYvjRYGfig%3D&reserved=0>
According to comments in the ASM, it seems like this is for Linux-based RAM boot (I saw further stuff for KVM, so it makes sense I guess?). It seems unfortunate it cannot be mapped into a known address range so that self-relocation is not necessary, but that's out of my scope to understand.

“Now, StandaloneMmPkg has similar (self-)relocation code too: https://github.com/tianocore/edk2/blob/17143c4837393d42c484b42d1789b85b2cff1aaf/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/StandaloneMmCoreEntryPoint.c#L379-L386<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftianocore%2Fedk2%2Fblob%2F17143c4837393d42c484b42d1789b85b2cff1aaf%2FStandaloneMmPkg%2FLibrary%2FStandaloneMmCoreEntryPoint%2FAArch64%2FStandaloneMmCoreEntryPoint.c%23L379-L386&data=04%7C01%7CBret.Barkelew%40microsoft.com%7C7f8b266a81d44c853f6108d941d6a804%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637613212486770613%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=HwixIAI%2FnnBRL4lWtdbooRRwps9gOj%2FEekr55DtXE44%3D&reserved=0>
Because I cannot find such elsewhere, I assume it must be for the same ARM virtualised environment as above. The binary it applies the Relocations to is documented to be the Standalone MM core, but in fact SecCore is located:
https://github.com/tianocore/edk2/blob/17143c4837393d42c484b42d1789b85b2cff1aaf/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/SetPermissions.c#L131-L158<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftianocore%2Fedk2%2Fblob%2F17143c4837393d42c484b42d1789b85b2cff1aaf%2FStandaloneMmPkg%2FLibrary%2FStandaloneMmCoreEntryPoint%2FAArch64%2FSetPermissions.c%23L131-L158&data=04%7C01%7CBret.Barkelew%40microsoft.com%7C7f8b266a81d44c853f6108d941d6a804%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637613212486770613%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=YcA%2B9yB8lHvCCSMOK8jbfxLXuO1KReB2zjNn9Jcqmc0%3D&reserved=0>

“This yields the following questions to me:
1) What even invokes Standalone MM on ARM? It is documented it is spawned during SEC, but I could not find any actual invocation.
2) Why does Standalone MM (self-)relocation locate SecCore? Should it not already have been relocated with the code from ArmPlatformPkg? Is Standalone MM embedded into ARM SecCore?
3) Why is SecCore the only module relocated? Are all others guaranteed to be "properly" loaded?
4) Is there maybe some high-level documented about the ARM boot flow? It seems to be significantly different from the x86 routes quite vastly.”

Hoping that one of you could get me closer to an answer for him. Also happy to take this to the greater mailing list, but thought I’d avoid churn.

Thanks in advance!
- Bret

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#78093): https://edk2.groups.io/g/devel/message/78093
Mute This Topic: https://groups.io/mt/84380729/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/edk2-devel-archive/attachments/20210722/2cc4d553/attachment.htm>