[edk2-devel] [PATCH v3] OvmfPkg: Remove unused print service driver (PrintDxe)
Yao, Jiewen
jiewen.yao at intel.com
Sun Jul 25 02:18:52 UTC 2021
Hi Philippe
I cannot find the Bugzilla for this patch.
Would you please file an Bugzilla and send a new version with the Bugzilla id?
Then I could merge it.
Thank you
Yao Jiewen
> -----Original Message-----
> From: Yao, Jiewen
> Sent: Wednesday, July 21, 2021 7:46 PM
> To: Philippe Mathieu-Daudé <philmd at redhat.com>; devel at edk2.groups.io
> Cc: Laszlo Ersek <lersek at redhat.com>; Ard Biesheuvel
> <ardb+tianocore at kernel.org>; Justen, Jordan L <jordan.l.justen at intel.com>;
> Brijesh Singh <brijesh.singh at amd.com>; Erdem Aktas
> <erdemaktas at google.com>; James Bottomley <jejb at linux.ibm.com>; Xu, Min
> M <min.m.xu at intel.com>; Tom Lendacky <thomas.lendacky at amd.com>
> Subject: RE: [PATCH v3] OvmfPkg: Remove unused print service driver (PrintDxe)
>
> Reviewed-by: Jiewen Yao <Jiewen.yao at intel.com>
>
> > -----Original Message-----
> > From: Philippe Mathieu-Daudé <philmd at redhat.com>
> > Sent: Wednesday, July 21, 2021 4:21 PM
> > To: devel at edk2.groups.io; Yao, Jiewen <jiewen.yao at intel.com>
> > Cc: Laszlo Ersek <lersek at redhat.com>; Ard Biesheuvel
> > <ardb+tianocore at kernel.org>; Justen, Jordan L <jordan.l.justen at intel.com>;
> > Brijesh Singh <brijesh.singh at amd.com>; Erdem Aktas
> > <erdemaktas at google.com>; James Bottomley <jejb at linux.ibm.com>; Xu, Min
> > M <min.m.xu at intel.com>; Tom Lendacky <thomas.lendacky at amd.com>
> > Subject: Re: [PATCH v3] OvmfPkg: Remove unused print service driver
> (PrintDxe)
> >
> > Ping?
> >
> > On 7/7/21 8:02 PM, Philippe Mathieu-Daudé wrote:
> > > From: Philippe Mathieu-Daude <philmd at redhat.com>
> > >
> > > PrintDxe produces gEfiPrint2ProtocolGuid and gEfiPrint2SProtocolGuid,
> > > and those are consumed by the following PrintLib instance:
> > >
> > >
> >
> MdeModulePkg/Library/DxePrintLibPrint2Protocol/DxePrintLibPrint2Protocol.inf
> > >
> > > However, none of the OVMF DSC files contain such a PrintLib class
> > > resolution, so none of the OVMF platforms need PrintDxe.
> > >
> > > Cc: Laszlo Ersek <lersek at redhat.com>
> > > Cc: Ard Biesheuvel <ardb+tianocore at kernel.org>
> > > Cc: Jordan Justen <jordan.l.justen at intel.com>
> > > Cc: Brijesh Singh <brijesh.singh at amd.com>
> > > Cc: Erdem Aktas <erdemaktas at google.com>
> > > Cc: James Bottomley <jejb at linux.ibm.com>
> > > Cc: Jiewen Yao <jiewen.yao at intel.com>
> > > Cc: Min Xu <min.m.xu at intel.com>
> > > Cc: Tom Lendacky <thomas.lendacky at amd.com>
> > > Suggested-by: Laszlo Ersek <lersek at redhat.com>
> > > Signed-off-by: Philippe Mathieu-Daude <philmd at redhat.com>
> > > ---
> > > OvmfPkg/AmdSev/AmdSevX64.dsc | 1 -
> > > OvmfPkg/Bhyve/BhyveX64.dsc | 1 -
> > > OvmfPkg/OvmfPkgIa32.dsc | 1 -
> > > OvmfPkg/OvmfPkgIa32X64.dsc | 1 -
> > > OvmfPkg/OvmfPkgX64.dsc | 1 -
> > > OvmfPkg/OvmfXen.dsc | 1 -
> > > OvmfPkg/AmdSev/AmdSevX64.fdf | 1 -
> > > OvmfPkg/Bhyve/BhyveX64.fdf | 1 -
> > > OvmfPkg/OvmfPkgIa32.fdf | 1 -
> > > OvmfPkg/OvmfPkgIa32X64.fdf | 1 -
> > > OvmfPkg/OvmfPkgX64.fdf | 1 -
> > > OvmfPkg/OvmfXen.fdf | 1 -
> > > 12 files changed, 12 deletions(-)
> > >
> > > diff --git a/OvmfPkg/AmdSev/AmdSevX64.dsc
> > b/OvmfPkg/AmdSev/AmdSevX64.dsc
> > > index 1d487befae08..d1974b4a6873 100644
> > > --- a/OvmfPkg/AmdSev/AmdSevX64.dsc
> > > +++ b/OvmfPkg/AmdSev/AmdSevX64.dsc
> > > @@ -722,7 +722,6 @@ [Components]
> > > DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
> > > PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
> > > }
> > > - MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
> > > MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
> > > MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
> > > MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
> > > diff --git a/OvmfPkg/Bhyve/BhyveX64.dsc b/OvmfPkg/Bhyve/BhyveX64.dsc
> > > index 006831449518..c08fa9bdbf5b 100644
> > > --- a/OvmfPkg/Bhyve/BhyveX64.dsc
> > > +++ b/OvmfPkg/Bhyve/BhyveX64.dsc
> > > @@ -673,7 +673,6 @@ [Components]
> > > DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
> > > PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
> > > }
> > > - MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
> > > MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
> > > MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
> > > MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
> > > diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc
> > > index f53efeae7986..dff4b97b37c0 100644
> > > --- a/OvmfPkg/OvmfPkgIa32.dsc
> > > +++ b/OvmfPkg/OvmfPkgIa32.dsc
> > > @@ -816,7 +816,6 @@ [Components]
> > > DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
> > > PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
> > > }
> > > - MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
> > > MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
> > > MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
> > > MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
> > > diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc
> > > index b3662e17f256..f3df655c990e 100644
> > > --- a/OvmfPkg/OvmfPkgIa32X64.dsc
> > > +++ b/OvmfPkg/OvmfPkgIa32X64.dsc
> > > @@ -830,7 +830,6 @@ [Components.X64]
> > > DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
> > > PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
> > > }
> > > - MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
> > > MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
> > > MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
> > > MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
> > > diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc
> > > index 0a237a905866..dc9a2720f9b2 100644
> > > --- a/OvmfPkg/OvmfPkgX64.dsc
> > > +++ b/OvmfPkg/OvmfPkgX64.dsc
> > > @@ -828,7 +828,6 @@ [Components]
> > > DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
> > > PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
> > > }
> > > - MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
> > > MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
> > > MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
> > > MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
> > > diff --git a/OvmfPkg/OvmfXen.dsc b/OvmfPkg/OvmfXen.dsc
> > > index 3c1ca6bfd493..aee91a61e7c3 100644
> > > --- a/OvmfPkg/OvmfXen.dsc
> > > +++ b/OvmfPkg/OvmfXen.dsc
> > > @@ -610,7 +610,6 @@ [Components]
> > > DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
> > > PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
> > > }
> > > - MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
> > > MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
> > > MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
> > > MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
> > > diff --git a/OvmfPkg/AmdSev/AmdSevX64.fdf
> > b/OvmfPkg/AmdSev/AmdSevX64.fdf
> > > index 9977b0f00a18..42f120d016e1 100644
> > > --- a/OvmfPkg/AmdSev/AmdSevX64.fdf
> > > +++ b/OvmfPkg/AmdSev/AmdSevX64.fdf
> > > @@ -234,7 +234,6 @@ [FV.DXEFV]
> > > INF MdeModulePkg/Application/UiApp/UiApp.inf
> > > INF OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.inf
> > > INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
> > > -INF MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
> > > INF MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
> > > INF MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
> > > INF MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
> > > diff --git a/OvmfPkg/Bhyve/BhyveX64.fdf b/OvmfPkg/Bhyve/BhyveX64.fdf
> > > index b3b4d44cef34..e8227f865f75 100644
> > > --- a/OvmfPkg/Bhyve/BhyveX64.fdf
> > > +++ b/OvmfPkg/Bhyve/BhyveX64.fdf
> > > @@ -233,7 +233,6 @@ [FV.DXEFV]
> > > INF MdeModulePkg/Universal/BdsDxe/BdsDxe.inf
> > > INF MdeModulePkg/Application/UiApp/UiApp.inf
> > > INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
> > > -INF MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
> > > INF MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
> > > INF MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
> > > INF MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
> > > diff --git a/OvmfPkg/OvmfPkgIa32.fdf b/OvmfPkg/OvmfPkgIa32.fdf
> > > index 04b41445ca34..031eb4225c53 100644
> > > --- a/OvmfPkg/OvmfPkgIa32.fdf
> > > +++ b/OvmfPkg/OvmfPkgIa32.fdf
> > > @@ -254,7 +254,6 @@ [FV.DXEFV]
> > > INF MdeModulePkg/Application/UiApp/UiApp.inf
> > > INF OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.inf
> > > INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
> > > -INF MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
> > > INF MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
> > > INF MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
> > > INF MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
> > > diff --git a/OvmfPkg/OvmfPkgIa32X64.fdf b/OvmfPkg/OvmfPkgIa32X64.fdf
> > > index 02fd8f0c413e..7194f08e6024 100644
> > > --- a/OvmfPkg/OvmfPkgIa32X64.fdf
> > > +++ b/OvmfPkg/OvmfPkgIa32X64.fdf
> > > @@ -255,7 +255,6 @@ [FV.DXEFV]
> > > INF MdeModulePkg/Application/UiApp/UiApp.inf
> > > INF OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.inf
> > > INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
> > > -INF MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
> > > INF MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
> > > INF MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
> > > INF MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
> > > diff --git a/OvmfPkg/OvmfPkgX64.fdf b/OvmfPkg/OvmfPkgX64.fdf
> > > index 5fa8c0895808..b304e3149d4f 100644
> > > --- a/OvmfPkg/OvmfPkgX64.fdf
> > > +++ b/OvmfPkg/OvmfPkgX64.fdf
> > > @@ -267,7 +267,6 @@ [FV.DXEFV]
> > > INF MdeModulePkg/Application/UiApp/UiApp.inf
> > > INF OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.inf
> > > INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
> > > -INF MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
> > > INF MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
> > > INF MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
> > > INF MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
> > > diff --git a/OvmfPkg/OvmfXen.fdf b/OvmfPkg/OvmfXen.fdf
> > > index aeb9336fd5b7..d109341d2890 100644
> > > --- a/OvmfPkg/OvmfXen.fdf
> > > +++ b/OvmfPkg/OvmfXen.fdf
> > > @@ -325,7 +325,6 @@ [FV.DXEFV]
> > > INF MdeModulePkg/Universal/BdsDxe/BdsDxe.inf
> > > INF MdeModulePkg/Application/UiApp/UiApp.inf
> > > INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
> > > -INF MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
> > > INF MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
> > > INF MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
> > > INF MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
> > >
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#78148): https://edk2.groups.io/g/devel/message/78148
Mute This Topic: https://groups.io/mt/84050542/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-
More information about the edk2-devel-archive
mailing list