[edk2-devel] [PATCH] CryptoPkg/BaseCryptLib: Enabled CryptSha512 for Smm drivers.

[Yao, Jiewen]

Would you please also:
1) Add Bugzilla and explain why SHA512 is needed.
2) Provide estimation on size difference. (Because SMM is size constrain environment.)

Thank you
Yao Jiewen

> -----Original Message-----
> From: devel at edk2.groups.io <devel at edk2.groups.io> On Behalf Of gaoliming
> Sent: Tuesday, June 1, 2021 8:48 AM
> To: devel at edk2.groups.io; Lu, XiaoyuX <xiaoyux.lu at intel.com>; Yao, Jiewen
> <jiewen.yao at intel.com>; Wang, Jian J <jian.j.wang at intel.com>; Jiang, Guomin
> <guomin.jiang at intel.com>
> Cc: Xue, ShengfengX <shengfengx.xue at intel.com>
> Subject: 回复: [edk2-devel] [PATCH] CryptoPkg/BaseCryptLib: Enabled
> CryptSha512 for Smm drivers.
> 
> Can you also update CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf to
> use CryptSha512.c?
> 
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: devel at edk2.groups.io <devel at edk2.groups.io> 代表 Xiaoyu Lu
> > 发送时间: 2021年6月1日 8:48
> > 收件人: devel at edk2.groups.io; jiewen.yao at intel.com;
> > jian.j.wang at intel.com; guomin.jiang at intel.com
> > 抄送: xiaoyux.lu at intel.com; shengfengx.xue at intel.com
> > 主题: [edk2-devel] [PATCH] CryptoPkg/BaseCryptLib: Enabled CryptSha512
> > for Smm drivers.
> >
> > From: Shengfengx Xue <shengfengx.xue at intel.com>
> >
> > in SmmCryptLib.inf, change CryptSha512NULL.c to CryptSha512.c.
> >
> > Signed-off-by: Shengfengx Xue <shengfengx.xue at intel.com>
> > ---
> >  CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf
> > b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf
> > index 07c376ce04..e6470d7a21 100644
> > --- a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf
> > +++ b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf
> > @@ -10,7 +10,7 @@
> >  #  RSA external functions, PKCS#7 SignedData sign functions,
> Diffie-Hellman
> > functions, and
> >  #  authenticode signature verification functions are not supported in
> this
> > instance.
> >  #
> > -#  Copyright (c) 2010 - 2020, Intel Corporation. All rights reserved.<BR>
> > +#  Copyright (c) 2010 - 2021, Intel Corporation. All rights reserved.<BR>
> >  #  SPDX-License-Identifier: BSD-2-Clause-Patent
> >  #
> >  ##
> > @@ -37,7 +37,7 @@
> >    Hash/CryptSha1.c
> >    Hash/CryptSha256.c
> >    Hash/CryptSm3.c
> > -  Hash/CryptSha512Null.c
> > +  Hash/CryptSha512.c
> >    Hmac/CryptHmacSha256.c
> >    Kdf/CryptHkdfNull.c
> >    Cipher/CryptAes.c
> > --
> > 2.26.2.windows.1
> >
> >
> >
> >
> >
> 
> 
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#75885): https://edk2.groups.io/g/devel/message/75885
Mute This Topic: https://groups.io/mt/83222970/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-