回复: [edk2-devel] [PATCH 1/1] MdePkg: Add new 16550-compatible Serial Port Subtypes to DBG2

[gaoliming]

Merge at 197e27c90aeb603eed98a2554746dd966f04fc28

> -----邮件原件-----
> 发件人: devel at edk2.groups.io <devel at edk2.groups.io> 代表 gaoliming
> 发送时间: 2021年6月1日 9:27
> 收件人: devel at edk2.groups.io; samer.el-haj-mahmoud at arm.com;
> mw at semihalf.com
> 抄送: liming.gao at intel.com; michael.d.kinney at intel.com; leif at nuviainc.com;
> ardb+tianocore at kernel.org; 'Sunny Wang' <Sunny.Wang at arm.com>;
> gjb at semihalf.com; upstream at semihalf.com
> 主题: 回复: [edk2-devel] [PATCH 1/1] MdePkg: Add new 16550-compatible
> Serial Port Subtypes to DBG2
> 
> Reviewed-by: Liming Gao <gaoliming at byosoft.com.cn>
> 
> > -----邮件原件-----
> > 发件人: devel at edk2.groups.io <devel at edk2.groups.io> 代表 Samer
> > El-Haj-Mahmoud
> > 发送时间: 2021年5月24日 18:58
> > 收件人: devel at edk2.groups.io; mw at semihalf.com
> > 抄送: liming.gao at intel.com; michael.d.kinney at intel.com;
> leif at nuviainc.com;
> > ardb+tianocore at kernel.org; Sunny Wang <Sunny.Wang at arm.com>;
> > gjb at semihalf.com; upstream at semihalf.com; Samer El-Haj-Mahmoud
> > <Samer.El-Haj-Mahmoud at arm.com>
> > 主题: Re: [edk2-devel] [PATCH 1/1] MdePkg: Add new 16550-compatible
> > Serial Port Subtypes to DBG2
> >
> > Reviewed-by: Samer El-Haj-Mahmoud
> <Samer.El-Haj-Mahmoud at arm.com>
> >
> >
> > > -----Original Message-----
> > > From: devel at edk2.groups.io <devel at edk2.groups.io> On Behalf Of
> Marcin
> > > Wojtas via groups.io
> > > Sent: Sunday, May 23, 2021 5:15 AM
> > > To: devel at edk2.groups.io
> > > Cc: liming.gao at intel.com; michael.d.kinney at intel.com;
> leif at nuviainc.com;
> > > ardb+tianocore at kernel.org; Samer El-Haj-Mahmoud <Samer.El-Haj-
> > > Mahmoud at arm.com>; Sunny Wang <Sunny.Wang at arm.com>;
> > > gjb at semihalf.com; upstream at semihalf.com; Marcin Wojtas
> > > <mw at semihalf.com>
> > > Subject: [edk2-devel] [PATCH 1/1] MdePkg: Add new 16550-compatible
> > > Serial Port Subtypes to DBG2
> > >
> > > The Microsoft Debug Port Table 2 (DBG2) specification revision
> > > May 31, 2017 adds support for 16550-compatible Serial Port
> > > Subtype with parameters defined in Generic Address Structure (GAS) [1]
> > >
> > > Reflect that in the EDK2 headers.
> > >
> > > [1] https://docs.microsoft.com/en-us/windows-
> > > hardware/drivers/bringup/acpi-debug-port-table
> > >
> > > Signed-off-by: Marcin Wojtas <mw at semihalf.com>
> > > ---
> > >  MdePkg/Include/IndustryStandard/DebugPort2Table.h
> > | 1 +
> > >  MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> |
> > 5
> > > +++++
> > >  2 files changed, 6 insertions(+)
> > >
> > > diff --git a/MdePkg/Include/IndustryStandard/DebugPort2Table.h
> > > b/MdePkg/Include/IndustryStandard/DebugPort2Table.h
> > > index 3faa30b76a..9ccfc1b1ee 100644
> > > --- a/MdePkg/Include/IndustryStandard/DebugPort2Table.h
> > > +++ b/MdePkg/Include/IndustryStandard/DebugPort2Table.h
> > > @@ -47,6 +47,7 @@ typedef struct {
> > >  #define
> > > EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_ARM_SBSA_GENERIC_UART
> > > 0x000e
> > >
> > >  #define   EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_DCC
> > > 0x000f
> > >
> > >  #define   EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_BCM2835_UART
> > > 0x0010
> > >
> > > +#define   EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_16550_WITH_GAS
> > > 0x0012
> > >
> > >  #define EFI_ACPI_DBG2_PORT_TYPE_1394
> > 0x8001
> > >
> > >  #define   EFI_ACPI_DBG2_PORT_SUBTYPE_1394_STANDARD
> > > 0x0000
> > >
> > >  #define EFI_ACPI_DBG2_PORT_TYPE_USB
> > 0x8002
> > >
> > > diff --git
> > > a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> > > b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> > > index 2066c7895e..7796796afe 100644
> > > ---
> > > a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> > > +++
> > > b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> > > @@ -100,6 +100,11 @@ typedef struct {
> > >  ///
> > >
> > >  #define
> > >
> >
> EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_
> > > BCM2835_UART              0x10
> > >
> > >
> > >
> > > +///
> > >
> > > +/// 16550-compatible with parameters defined in Generic Address
> > Structure
> > >
> > > +///
> > >
> > > +#define
> > >
> >
> EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_
> > > 16550_WITH_GAS            0x12
> > >
> > > +
> > >
> > >  //
> > >
> > >  // Interrupt Type
> > >
> > >  //
> > >
> > > --
> > > 2.29.0
> > >
> > >
> > >
> > > -=-=-=-=-=-=
> > > Groups.io Links: You receive all messages sent to this group.
> > > View/Reply Online (#75464):
> > https://edk2.groups.io/g/devel/message/75464
> > > Mute This Topic: https://groups.io/mt/83024903/1945644
> > > Group Owner: devel+owner at edk2.groups.io
> > > Unsubscribe: https://edk2.groups.io/g/devel/unsub [samer.el-haj-
> > > mahmoud at arm.com]
> > > -=-=-=-=-=-=
> > >
> >
> > IMPORTANT NOTICE: The contents of this email and any attachments are
> > confidential and may also be privileged. If you are not the intended
> recipient,
> > please notify the sender immediately and do not disclose the contents to
> any
> > other person, use it for any purpose, or store or copy the information
in
> any
> > medium. Thank you.
> >
> >
> >
> >
> >
> 
> 
> 
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#75940): https://edk2.groups.io/g/devel/message/75940
Mute This Topic: https://groups.io/mt/83252551/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-