回复: [edk2-devel] [PATCH 1/1] MdePkg: Update DBG2 and SPCR header with NVIDIA 16550 Subtype
gaoliming
gaoliming at byosoft.com.cn
Wed Jun 2 05:56:55 UTC 2021
Merge at fdf3666f01a2dd02d83a808f609b9c744a74c652
发件人: devel at edk2.groups.io <devel at edk2.groups.io> 代表 gaoliming
发送时间: 2021年5月21日 13:28
收件人: devel at edk2.groups.io; gaoliming at byosoft.com.cn; ashishsingha at nvidia.
com; 'Samer El-Haj-Mahmoud' <Samer.El-Haj-Mahmoud at arm.com>;
michael.d.kinney at intel.com; zhiguang.liu at intel.com
主题: 回复: [edk2-devel] [PATCH 1/1] MdePkg: Update DBG2 and SPCR header
with NVIDIA 16550 Subtype
Ashish:
Sorry. I miss the patch cover letter. I see this subtype is defined in
https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/acpi-debug
-port-table.
So, I agree this fix. Reviewed-by: Liming Gao <gaoliming at byosoft.com.cn
<mailto:gaoliming at byosoft.com.cn> >
Now, we are in Soft Feature Freeze for edk2-stable202105. I will merge
this patch once edk2-stable202105 is created.
Thanks
Liming
发件人: devel at edk2.groups.io <mailto:devel at edk2.groups.io>
<devel at edk2.groups.io <mailto:devel at edk2.groups.io> > 代表 gaoliming
发送时间: 2021年5月21日 13:20
收件人: devel at edk2.groups.io <mailto:devel at edk2.groups.io> ;
ashishsingha at nvidia.com <mailto:ashishsingha at nvidia.com> ; 'Samer
El-Haj-Mahmoud' <Samer.El-Haj-Mahmoud at arm.com
<mailto:Samer.El-Haj-Mahmoud at arm.com> >; michael.d.kinney at intel.com
<mailto:michael.d.kinney at intel.com> ; zhiguang.liu at intel.com
<mailto:zhiguang.liu at intel.com>
主题: 回复: [edk2-devel] [PATCH 1/1] MdePkg: Update DBG2 and SPCR header
with NVIDIA 16550 Subtype
Ashish:
Is NVIDIA 16550 Subtype defined in the public spec? If yes, can you share
the link?
Thanks
Liming
发件人: devel at edk2.groups.io <mailto:devel at edk2.groups.io>
<devel at edk2.groups.io <mailto:devel at edk2.groups.io> > 代表 Ashish Singhal
发送时间: 2021年5月21日 4:33
收件人: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud at arm.com
<mailto:Samer.El-Haj-Mahmoud at arm.com> >; devel at edk2.groups.io
<mailto:devel at edk2.groups.io> ; michael.d.kinney at intel.com
<mailto:michael.d.kinney at intel.com> ; gaoliming at byosoft.com.cn
<mailto:gaoliming at byosoft.com.cn> ; zhiguang.liu at intel.com <mailto:zhiguang.
liu at intel.com>
主题: Re: [edk2-devel] [PATCH 1/1] MdePkg: Update DBG2 and SPCR header with
NVIDIA 16550 Subtype
Hello Michael/Gao/Zhiguang,
Any update on this?
Thanks
Ashish
_____
From: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud at arm.com
<mailto:Samer.El-Haj-Mahmoud at arm.com> >
Sent: Tuesday, May 18, 2021 3:14 PM
To: devel at edk2.groups.io <mailto:devel at edk2.groups.io>
<devel at edk2.groups.io <mailto:devel at edk2.groups.io> >; Ashish Singhal
<ashishsingha at nvidia.com <mailto:ashishsingha at nvidia.com> >;
michael.d.kinney at intel.com <mailto:michael.d.kinney at intel.com>
<michael.d.kinney at intel.com <mailto:michael.d.kinney at intel.com> >;
gaoliming at byosoft.com.cn <mailto:gaoliming at byosoft.com.cn>
<gaoliming at byosoft.com.cn <mailto:gaoliming at byosoft.com.cn> >;
zhiguang.liu at intel.com <mailto:zhiguang.liu at intel.com> <zhiguang.liu at intel.
com <mailto:zhiguang.liu at intel.com> >
Cc: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud at arm.com
<mailto:Samer.El-Haj-Mahmoud at arm.com> >
Subject: RE: [edk2-devel] [PATCH 1/1] MdePkg: Update DBG2 and SPCR header
with NVIDIA 16550 Subtype
External email: Use caution opening links or attachments
Reviewed-by: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud at arm.com
<mailto:Samer.El-Haj-Mahmoud at arm.com> >
> -----Original Message-----
> From: devel at edk2.groups.io <mailto:devel at edk2.groups.io>
<devel at edk2.groups.io <mailto:devel at edk2.groups.io> > On Behalf Of Ashish
> Singhal via groups.io
> Sent: Tuesday, May 18, 2021 2:38 PM
> To: devel at edk2.groups.io <mailto:devel at edk2.groups.io> ;
michael.d.kinney at intel.com <mailto:michael.d.kinney at intel.com> ;
> gaoliming at byosoft.com.cn <mailto:gaoliming at byosoft.com.cn> ;
zhiguang.liu at intel.com <mailto:zhiguang.liu at intel.com>
> Cc: Ashish Singhal <ashishsingha at nvidia.com
<mailto:ashishsingha at nvidia.com> >
> Subject: [edk2-devel] [PATCH 1/1] MdePkg: Update DBG2 and SPCR header with
> NVIDIA 16550 Subtype
>
> Add macros for NVIDIA 16550 UART specific debug port subtype in both
> DBG2 as well as SPCR header file.
>
> Signed-off-by: Ashish Singhal <ashishsingha at nvidia.com
<mailto:ashishsingha at nvidia.com> >
>
> ---
> MdePkg/Include/IndustryStandard/DebugPort2Table.h | 1 +
> .../IndustryStandard/SerialPortConsoleRedirectionTable.h | 5 +++++
> 2 files changed, 6 insertions(+)
>
> diff --git a/MdePkg/Include/IndustryStandard/DebugPort2Table.h
> b/MdePkg/Include/IndustryStandard/DebugPort2Table.h
> index 3faa30b76a..6a6fd2590e 100644
> --- a/MdePkg/Include/IndustryStandard/DebugPort2Table.h
> +++ b/MdePkg/Include/IndustryStandard/DebugPort2Table.h
> @@ -43,6 +43,7 @@ typedef struct {
> #define EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_FULL_16550
> 0x0000
> #define
> EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_16550_SUBSET_COMPATIBLE_WITH_
> MS_DBGP_SPEC 0x0001
> #define EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_ARM_PL011_UART
> 0x0003
> +#define EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_NVIDIA_16550_UART
> 0x0005
> #define
> EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_ARM_SBSA_GENERIC_UART_2X
> 0x000d
> #define EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_ARM_SBSA_GENERIC_UART
> 0x000e
> #define EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_DCC
> 0x000f
> diff --git
> a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> index 2066c7895e..ba19567f52 100644
> --- a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> +++ b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.
> +++ h
> @@ -80,6 +80,11 @@ typedef struct {
> ///
> #define
> EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_AR
> M_PL011_UART 0x03
>
> +///
> +/// NVIDIA 16550 UART
> +///
> +#define
> EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_NV
> IDIA_16550_UART 0x05
> +
> ///
> /// ARM SBSA Generic UART (2.x) supporting 32-bit only accesses
[deprecated]
> ///
> --
> 2.17.1
>
>
>
>
>
IMPORTANT NOTICE: The contents of this email and any attachments are
confidential and may also be privileged. If you are not the intended
recipient, please notify the sender immediately and do not disclose the
contents to any other person, use it for any purpose, or store or copy the
information in any medium. Thank you.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#75941): https://edk2.groups.io/g/devel/message/75941
Mute This Topic: https://groups.io/mt/83252563/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/edk2-devel-archive/attachments/20210602/3063c8f1/attachment.htm>
More information about the edk2-devel-archive
mailing list