回复: [edk2-devel] [edk2][PATCH] MdePkg : Add IPMI Macro and Structure Defintions to resolve the IPMI build error

[gaoliming]

KARP:
  I don't find the source code in
edk2-platforms\Features\Intel\OutOfBandManagement\IpmiFeaturePkg to consume
new struct IPMI_SET_BOOT_OPTIONS_RESPONSE. Can you point which source file
depend on new definition?

Thanks
Liming
> -----邮件原件-----
> 发件人: devel at edk2.groups.io <devel at edk2.groups.io> 代表 Oram, Isaac
> W
> 发送时间: 2021年6月11日 8:13
> 收件人: KARPAGAVINAYAGAM, MANICKAVASAKAM
> <manickavasakamk at ami.com>; devel at edk2.groups.io
> 抄送: Desimone, Nathaniel L <nathaniel.l.desimone at intel.com>;
> Felixp at ami.com; DOPPALAPUDI, HARIKRISHNA <harikrishnad at ami.com>;
> Jha, Manish <manishj at ami.com>; Bobroff, Zachary <zacharyb at ami.com>
> 主题: Re: [edk2-devel] [edk2][PATCH] MdePkg : Add IPMI Macro and
> Structure Defintions to resolve the IPMI build error
> 
> Please comment the following commenting per normal style
>
/*--------------------------------------------------------------------------
--------------
>    Definitions for Get BMC Execution Context
>
----------------------------------------------------------------------------
------------*/
> 
> Which would correctly be:
> //
> // Definitions for Get BMC Execution Context
> //
> 
> Please don't use EFI_ or Efi prefix for items that are not part of UEFI
owned
> specifications.  Please correct:
> EFI_IPMI_MSG_GET_BMC_EXEC_RSP
> EFI_FIRMWARE_GET_BMC_EXECUTION_CONTEXT
> EFI_FIRMWARE_BMC_IN_FULL_RUNTIME
> EFI_FIRMWARE_BMC_IN_FORCED_UPDATE_MODE
> and any uses.
> 
> Thanks,
> Isaac
> 
> -----Original Message-----
> From: manickavasakam karpagavinayagam <manickavasakamk at ami.com>
> Sent: Thursday, June 10, 2021 4:41 PM
> To: devel at edk2.groups.io
> Cc: Oram, Isaac W <isaac.w.oram at intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone at intel.com>; Felixp at ami.com; DOPPALAPUDI,
> HARIKRISHNA <harikrishnad at ami.com>; Jha, Manish <manishj at ami.com>;
> Bobroff, Zachary <zacharyb at ami.com>
> Subject: [edk2][PATCH] MdePkg : Add IPMI Macro and Structure Defintions to
> resolve the IPMI build error
> 
> Build error reported for missing structures
> IPMI_SET_BOOT_OPTIONS_RESPONSE,
> EFI_IPMI_MSG_GET_BMC_EXEC_RSP and macros
> EFI_FIRMWARE_GET_BMC_EXECUTION_CONTEXT
> EFI_FIRMWARE_BMC_IN_FULL_RUNTIME/EFI_FIRMWARE_BMC_IN_FORCE
> D_UPDATE_MODE
> when using
> edk2-platforms\Features\Intel\OutOfBandManagement\IpmiFeaturePkg
> ---
>  MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h  |  4 ++++
>  MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h | 19
> +++++++++++++++++++
>  2 files changed, 23 insertions(+)
> 
> diff --git a/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h
> b/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h
> index 79db55523d..d7cdd3a865 100644
> --- a/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h
> +++ b/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h
> @@ -186,6 +186,10 @@ typedef struct {
>    UINT8                                  ParameterData[0];
> 
>  } IPMI_SET_BOOT_OPTIONS_REQUEST;
> 
> 
> 
> +typedef struct {
> 
> +  UINT8   CompletionCode:8;
> 
> +} IPMI_SET_BOOT_OPTIONS_RESPONSE;
> 
> +
> 
>  //
> 
>  //  Definitions for Get System Boot options command
> 
>  //
> 
> diff --git a/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h
> b/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h
> index 2d892dbd5a..1c692cc792 100644
> --- a/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h
> +++ b/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h
> @@ -17,4 +17,23 @@
>  // All Firmware commands and their structure definitions to follow here
> 
>  //
> 
> 
> 
>
+/*-------------------------------------------------------------------------
---------------
> 
> +    Definitions for Get BMC Execution Context
> 
>
+---------------------------------------------------------------------------
-------------*/
> 
> +#define EFI_FIRMWARE_GET_BMC_EXECUTION_CONTEXT  0x23
> 
> +
> 
> +//
> 
> +//  Constants and Structure definitions for "Get Device ID" command to
> follow here
> 
> +//
> 
> +typedef struct {
> 
> +  UINT8   CurrentExecutionContext;
> 
> +  UINT8   PartitionPointer;
> 
> +} EFI_IPMI_MSG_GET_BMC_EXEC_RSP;
> 
> +
> 
> +//
> 
> +// Current Execution Context responses
> 
> +//
> 
> +#define EFI_FIRMWARE_BMC_IN_FULL_RUNTIME        0x10
> 
> +#define EFI_FIRMWARE_BMC_IN_FORCED_UPDATE_MODE  0x11
> 
> +
> 
>  #endif
> 
> --
> 2.25.0.windows.1
> 
> 
> Please consider the environment before printing this email.
> 
> The information contained in this message may be confidential and
> proprietary to American Megatrends (AMI).  This communication is intended
> to be read only by the individual or entity to whom it is addressed or by
their
> designee. If the reader of this message is not the intended recipient, you
are
> on notice that any distribution of this message, in any form, is strictly
> prohibited.  Please promptly notify the sender by reply e-mail or by
> telephone at 770-246-8600, and then delete or destroy all copies of the
> transmission.
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#76362): https://edk2.groups.io/g/devel/message/76362
Mute This Topic: https://groups.io/mt/83461411/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-