[edk2-devel] [edk2-test][PATCH v2 1/1] uefi-sct/SctPkg: Not create event with TPL_HIGH_LEVEL

[Heinrich Schuchardt]

On 11.06.21 10:35, Sunny Wang wrote:
> The commits a9d1fb58 and ae7e5477b555 caused SCT BS.CreateEvent failures.
>
> Section 7.1 of the UEFI Spec states that TPL_HIGH_LEVEL is designed for
> exclusive use by the firmware. The creation of events by UEFI
> applications, UEFI drivers, and UEFI OS Loaders should not use this TPL
> level.
>
> Therefore, revert TPL_HIGH_LEVEL change in commits a9d1fb58 and
> ae7e5477b555 to not create event with TPL_HIGH_LEVEL to be compliant
> with UEFI Spec and fix the failures.
>
> For more information, https://edk2.groups.io/g/devel/message/76338
>
> Cc: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud at arm.com>
> Cc: G Edhaya Chandran <edhaya.chandran at arm.com>
> Cc: Barton Gao <gaojie at byosoft.com.cn>
> Cc: Heinrich Schuchardt <xypron.glpk at gmx.de>
> Cc: Michael D Kinney <michael.d.kinney at intel.com>
> Signed-off-by: Sunny Wang <sunny.wang at arm.com>

Acked-by: Heinrich Schuchardt <xypron.glpk at gmx.de>

> ---
>  .../EventTimerTaskPriorityServicesBBTestCreateEvent.c        | 5 +----
>  .../EventTimerTaskPriorityServicesBBTestCreateEventEx.c      | 4 +---
>  2 files changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c
> index a7e7366e..d5c033f7 100644
> --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c
> +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c
> @@ -2,6 +2,7 @@
>
>    Copyright 2006 - 2012 Unified EFI, Inc.<BR>
>    Copyright (c) 2010 - 2012, Intel Corporation. All rights reserved.<BR>
> +  Copyright (c) 2021, ARM Limited. All rights reserved.
>
>    This program and the accompanying materials
>    are licensed and made available under the terms and conditions of the BSD License
> @@ -190,7 +191,6 @@ BBTestCreateEvent_Conf_Sub1 (
>    EFI_TPL             NotifyTpls[] = {
>                          TPL_CALLBACK,
>                          TPL_NOTIFY,
> -                        TPL_HIGH_LEVEL,
>                          0
>                        };
>    EFI_TEST_ASSERTION  AssertionType;
> @@ -342,7 +342,6 @@ BBTestCreateEvent_Conf_Sub3 (
>    EFI_TPL             NotifyTpls[] = {
>                          TPL_CALLBACK,
>                          TPL_NOTIFY,
> -                        TPL_HIGH_LEVEL,
>                          0
>                        };
>    EFI_TEST_ASSERTION  AssertionType;
> @@ -407,7 +406,6 @@ BBTestCreateEvent_Conf_Sub4 (
>    EFI_TPL             NotifyTpls[] = {
>                          TPL_CALLBACK,
>                          TPL_NOTIFY,
> -                        TPL_HIGH_LEVEL,
>                          0
>                        };
>    EFI_TEST_ASSERTION  AssertionType;
> @@ -482,7 +480,6 @@ BBTestCreateEvent_Func_Sub1 (
>    EFI_TPL             NotifyTpls[] = {
>                          TPL_CALLBACK,
>                          TPL_NOTIFY,
> -                        TPL_HIGH_LEVEL,
>                          0
>                        };
>    EFI_TEST_ASSERTION  AssertionType;
> diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEventEx.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEventEx.c
> index eb458de5..03b7ae6e 100644
> --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEventEx.c
> +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEventEx.c
> @@ -2,6 +2,7 @@
>
>    Copyright 2006 - 2016 Unified EFI, Inc.<BR>
>    Copyright (c) 2010 - 2019, Intel Corporation. All rights reserved.<BR>
> +  Copyright (c) 2021, ARM Limited. All rights reserved.
>
>    This program and the accompanying materials
>    are licensed and made available under the terms and conditions of the BSD License
> @@ -228,7 +229,6 @@ BBTestCreateEventEx_Conf_Sub1 (
>    EFI_TPL             NotifyTpls[] = {
>                          TPL_CALLBACK,
>                          TPL_NOTIFY,
> -                        TPL_HIGH_LEVEL,
>                          0
>                        };
>    EFI_GUID            *EventGroups[] = {
> @@ -318,7 +318,6 @@ BBTestCreateEventEx_Conf_Sub2 (
>    EFI_TPL             NotifyTpls[] = {
>                          TPL_CALLBACK,
>                          TPL_NOTIFY,
> -                        TPL_HIGH_LEVEL,
>                          0
>                        };
>    EFI_GUID            *EventGroups[] = {
> @@ -413,7 +412,6 @@ BBTestCreateEventEx_Conf_Sub3 (
>    EFI_TPL             NotifyTpls[] = {
>                          TPL_CALLBACK,
>                          TPL_NOTIFY,
> -                        TPL_HIGH_LEVEL,
>                          0
>                        };
>    EFI_GUID            *EventGroups[] = {
>



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#76377): https://edk2.groups.io/g/devel/message/76377
Mute This Topic: https://groups.io/mt/83464380/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-