[edk2-devel] [edk2-platforms][PATCH] IpmiFeaturePkg : Rename IPMI Macro and Structure Defintions

Oram, Isaac W isaac.w.oram at intel.com
Fri Jun 11 22:15:17 UTC 2021

Reviewed-by: Isaac Oram <isaac.w.oram at intel.com>

-----Original Message-----
From: manickavasakam karpagavinayagam <manickavasakamk at ami.com> 
Sent: Friday, June 11, 2021 2:52 PM
To: devel at edk2.groups.io
Cc: Oram, Isaac W <isaac.w.oram at intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone at intel.com>; Felixp at ami.com; DOPPALAPUDI, HARIKRISHNA <harikrishnad at ami.com>; Jha, Manish <manishj at ami.com>; Bobroff, Zachary <zacharyb at ami.com>; KARPAGAVINAYAGAM, MANICKAVASAKAM <manickavasakamk at ami.com>; gaoliming at byosoft.com.cn
Subject: [edk2-platforms][PATCH] IpmiFeaturePkg : Rename IPMI Macro and Structure Defintions

 .../IpmiFeaturePkg/GenericIpmi/Dxe/IpmiInit.c             | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Dxe/IpmiInit.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Dxe/IpmiInit.c
index 1e0c132508..d788b48867 100644
--- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Dxe/IpmiInit.c
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Dxe/IpmiInit.c
@@ -242,7 +242,7 @@ Returns:
   EFI_STATUS                      Status;

   UINT32                          DataSize;

   SM_CTRL_INFO                    *pBmcInfo;

-  EFI_IPMI_MSG_GET_BMC_EXEC_RSP   *pBmcExecContext;

+  IPMI_MSG_GET_BMC_EXEC_RSP       *pBmcExecContext;

   UINT32                          Retries;


   EFI_VIDEOPRINT_PROTOCOL         *VideoPrintProtocol;

@@ -301,14 +301,14 @@ Returns:
     Status = IpmiSendCommand (


                IPMI_NETFN_FIRMWARE, 0,



                NULL, 0,

                IpmiInstance->TempData, &DataSize



-    pBmcExecContext = (EFI_IPMI_MSG_GET_BMC_EXEC_RSP*)&IpmiInstance->TempData[0];

+    pBmcExecContext = (IPMI_MSG_GET_BMC_EXEC_RSP*)&IpmiInstance->TempData[0];

     DEBUG ((DEBUG_INFO, "[IPMI] Operational status of BMC: 0x%x\n", pBmcExecContext->CurrentExecutionContext));

-    if ((pBmcExecContext->CurrentExecutionContext == EFI_FIRMWARE_BMC_IN_FORCED_UPDATE_MODE) &&

+    if ((pBmcExecContext->CurrentExecutionContext == IPMI_BMC_IN_FORCED_UPDATE_MODE) &&

         !EFI_ERROR (Status)) {

       DEBUG ((DEBUG_ERROR, "[IPMI] BMC in Forced Update mode, skip waiting for BMC_READY.\n"));

       IpmiInstance->BmcStatus = BMC_UPDATE_IN_PROGRESS;


Please consider the environment before printing this email.

The information contained in this message may be confidential and proprietary to American Megatrends (AMI).  This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited.  Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.

Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#76414): https://edk2.groups.io/g/devel/message/76414
Mute This Topic: https://groups.io/mt/83479952/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]

More information about the edk2-devel-archive mailing list