[edk2-devel] [PATCH v1 0/1] SpellCheck plugin inspects fewer files when run on Linux

Kun Qin kuqin12 at gmail.com
Sat Jun 12 05:04:30 UTC 2021


REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3454

When spellcheck plugin invokes cspell to check files, it uses wildcard
path patterns, i.e. <package>/**/*.h.

On Linux system, this will be expanded by the shell therefore fewer files
will be picked up than speficied through original command line.

To resolve this issue, the path needs double quoting. So that the shell
does not expand and the input parameter is passed to cspell to expand.

Patch v1 branch: https://github.com/kuqin12/edk2/tree/exp_shell_v1

Cc: Sean Brogan <sean.brogan at microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew at microsoft.com>
Cc: Michael D Kinney <michael.d.kinney at intel.com>
Cc: Liming Gao <gaoliming at byosoft.com.cn>

Sean Brogan (1):
  Pytool: SpellCheck: Defer path expansion in cspell parameters

 .pytool/Plugin/SpellCheck/SpellCheck.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

-- 
2.31.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#76427): https://edk2.groups.io/g/devel/message/76427
Mute This Topic: https://groups.io/mt/83484916/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-





More information about the edk2-devel-archive mailing list