[edk2-devel] reg: Static Code Analyzer Issues

[Sivaraman Nainar]

Hello Maciej:

This is regarding the Code analyzer issue reported on the PxeBcDhcp4CallBack() and PxeBcDhcp6CallBack() functions of UEFIPXEBC Driver.

In both the functions the allowed event are Dhcp4RcvdOffer, Dhcp4SelectOffer, Dhcp4SendDiscover, Dhcp4RcvdAck. If any other event comes as input it will exit in beginning itself.


  if ((Dhcp4Event != Dhcp4RcvdOffer) &&

      (Dhcp4Event != Dhcp4SelectOffer) &&

      (Dhcp4Event != Dhcp4SendDiscover) &&

      (Dhcp4Event != Dhcp4RcvdAck)) {

    return EFI_SUCCESS;

Later below switch case handling the default case which is not reachable. This is applicable for both the callback functions.

switch (Dhcp4Event) {



default:

            break;

          }

I assume this code is a not reachable code and can be removed. Please feedback.

-Siva
-The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#76592): https://edk2.groups.io/g/devel/message/76592
Mute This Topic: https://groups.io/mt/83579883/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/edk2-devel-archive/attachments/20210616/70e477e2/attachment.htm>