回复: [edk2-devel] [PATCH v2 4/4] Azurepipeline: SpellCheck: Enforce Node dependency to use version 14.x

[gaoliming]

Acked-by: Liming Gao <gaoliming at byosoft.com.cn>

> -----邮件原件-----
> 发件人: Kun Qin <kuqin12 at gmail.com>
> 发送时间: 2021年6月17日 5:08
> 收件人: devel at edk2.groups.io
> 抄送: Sean Brogan <sean.brogan at microsoft.com>; Bret Barkelew
> <Bret.Barkelew at microsoft.com>; Michael D Kinney
> <michael.d.kinney at intel.com>; Liming Gao <gaoliming at byosoft.com.cn>;
> Ard Biesheuvel <ardb at kernel.org>
> 主题: Re: [edk2-devel] [PATCH v2 4/4] Azurepipeline: SpellCheck: Enforce
> Node dependency to use version 14.x
> 
> Hi pipeline maintainers,
> 
> Could you please help reviewing this specific patch?
> 
> Thanks to Ard, the other patches in this series are already reviewed and
> merged.
> 
> Regards,
> Kun
> 
> On 06/14/2021 11:34, Kun Qin via groups.io wrote:
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3445
> >
> > Per update from Cspell tool, the minimal requirement of Cspell 5.x
> > regarding Node is 12 and above. This has caused multple Cspell failures
> > during CI build validation:
> > "Failed to process "**.c" TypeError: text.matchAll(...) is not a function
> > or its return value is not iterable"
> >
> > This change updates the lowest required node version to 14.x to support
> > Cspell functionalities.
> >
> > Cc: Sean Brogan <sean.brogan at microsoft.com>
> > Cc: Bret Barkelew <Bret.Barkelew at microsoft.com>
> > Cc: Michael D Kinney <michael.d.kinney at intel.com>
> > Cc: Liming Gao <gaoliming at byosoft.com.cn>
> >
> > Signed-off-by: Kun Qin <kuqin12 at gmail.com>
> > Reviewed-by: Ard Biesheuvel <ardb at kernel.org>
> > ---
> >
> > Notes:
> >      v2:
> >      - Added reviewed-by tag [Ard]
> >
> >   .azurepipelines/templates/spell-check-prereq-steps.yml | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/.azurepipelines/templates/spell-check-prereq-steps.yml
> b/.azurepipelines/templates/spell-check-prereq-steps.yml
> > index e1570d4f2aac..98ee3cfa6bc6 100644
> > --- a/.azurepipelines/templates/spell-check-prereq-steps.yml
> > +++ b/.azurepipelines/templates/spell-check-prereq-steps.yml
> > @@ -13,7 +13,7 @@ parameters:
> >   steps:
> >   - task: NodeTool at 0
> >     inputs:
> > -    versionSpec: '10.x'
> > +    versionSpec: '14.x'
> >       #checkLatest: false # Optional
> >     condition: and(gt(variables.pkg_count, 0), succeeded())
> >
> >




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#76637): https://edk2.groups.io/g/devel/message/76637
Mute This Topic: https://groups.io/mt/83596143/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-