[edk2-devel] [PATCH] UefiCpuPkg/SmmCommunication: Remove out-dated comments

Ni, Ray ray.ni at intel.com
Tue Mar 23 01:15:27 UTC 2021


The comments in PiSmmCommunicationPei.c describe the whole memory
layout of the SMRAM regarding the SMM communication.

But SHA-1: 8b1d14939053b63d80355465649c50f9f391a64a
PiSmmCommunicationSmm: Deprecate SMM Communication ACPI Table
removed the code that produces the ACPI Table.

This change updates the accordingly comments.

Signed-off-by: Ray Ni <ray.ni at intel.com>
Cc: Eric Dong <eric.dong at intel.com>
Cc: Laszlo Ersek <lersek at redhat.com>
Cc: Rahul Kumar <rahul1.kumar at intel.com>
---
 .../PiSmmCommunication/PiSmmCommunicationPei.c   | 16 +++++-----------
 1 file changed, 5 insertions(+), 11 deletions(-)

diff --git a/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c b/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c
index 68e5003ad4..110165b20b 100644
--- a/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c
+++ b/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c
@@ -1,7 +1,7 @@
 /** @file
 PiSmmCommunication PEI Driver.
 
-Copyright (c) 2010 - 2015, Intel Corporation. All rights reserved.<BR>
+Copyright (c) 2010 - 2021, Intel Corporation. All rights reserved.<BR>
 SPDX-License-Identifier: BSD-2-Clause-Patent
 
 **/
@@ -47,16 +47,10 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
   +----------------------------------+<--
   | EFI_SMM_COMMUNICATION_CONTEXT    |
   |   SwSmiNumber                    | <- SMRAM
-  |   BufferPtrAddress               |----------------
-  +----------------------------------+                |
-                                                      |
-  +----------------------------------+                |
-  | EFI_SMM_COMMUNICATION_ACPI_TABLE |                |
-  |   SwSmiNumber                    | <- AcpiTable   |
-  |   BufferPtrAddress               |---             |
-  +----------------------------------+   |            |
-                                         |            |
-  +----------------------------------+<---------------
+  |   BufferPtrAddress               |---
+  +----------------------------------+   |
+                                         |
+  +----------------------------------+<--
   | Communication Buffer Pointer     | <- AcpiNvs
   +----------------------------------+---
                                          |
-- 
2.27.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#73155): https://edk2.groups.io/g/devel/message/73155
Mute This Topic: https://groups.io/mt/81541408/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-






More information about the edk2-devel-archive mailing list