[edk2-devel] [EXTERNAL] [PATCH v1 1/1] UnitTestFrameworkPkg: Sample unit test hangs when running in OVMF/QEMU

[Michael D Kinney]

Pushed commit to edk2/master:
	https://github.com/tianocore/edk2/commit/f297b7f20010711e36e981fe45645302cc9d109d

GitHub PR:
	https://github.com/tianocore/edk2/pull/1623

Mike


> -----Original Message-----
> From: Kinney, Michael D <michael.d.kinney at intel.com>
> Sent: Monday, May 3, 2021 5:38 PM
> To: devel at edk2.groups.io; bret.barkelew at microsoft.com; Getnat Ejigu <getnatejigu at gmail.com>; Kinney, Michael D
> <michael.d.kinney at intel.com>
> Cc: Sean Brogan <sean.brogan at microsoft.com>
> Subject: RE: [edk2-devel] [EXTERNAL] [PATCH v1 1/1] UnitTestFrameworkPkg: Sample unit test hangs when running in OVMF/QEMU
> 
> I found one more place that is missing EFIAPI:
> 
> STATIC
> VOID
> UnitTestLogFailure (
>   IN FAILURE_TYPE  FailureType,
>   IN CONST CHAR8   *Format,
>   ...
>   )
> {
> 
> 
> I will fix this one too in the PR.
> 
> Mike
> 
> 
> 
> From: Kinney, Michael D <michael.d.kinney at intel.com>
> Sent: Monday, May 3, 2021 5:28 PM
> To: devel at edk2.groups.io; bret.barkelew at microsoft.com; Getnat Ejigu <getnatejigu at gmail.com>; Kinney, Michael D
> <michael.d.kinney at intel.com>
> Cc: Sean Brogan <sean.brogan at microsoft.com>
> Subject: RE: [edk2-devel] [EXTERNAL] [PATCH v1 1/1] UnitTestFrameworkPkg: Sample unit test hangs when running in OVMF/QEMU
> 
> Reviewed-by: Michael D Kinney mailto:michael.d.kinney at intel.com
> 
> Yes.  I will submit PR.
> 
> Mike
> 
> From: mailto:devel at edk2.groups.io <mailto:devel at edk2.groups.io> On Behalf Of Bret Barkelew via groups.io
> Sent: Friday, April 30, 2021 2:16 PM
> To: mailto:devel at edk2.groups.io; Getnat Ejigu <mailto:getnatejigu at gmail.com>
> Cc: Kinney, Michael D <mailto:michael.d.kinney at intel.com>; Sean Brogan <mailto:sean.brogan at microsoft.com>
> Subject: Re: [edk2-devel] [EXTERNAL] [PATCH v1 1/1] UnitTestFrameworkPkg: Sample unit test hangs when running in OVMF/QEMU
> 
> Mike,
> 
> Can you stage the PR for this? Thanks!
> 
> - Bret
> 
> From: mailto:bret.barkelew=microsoft.com at groups.io
> Sent: Friday, April 30, 2021 2:16 PM
> To: mailto:getnatejigu at gmail.com; mailto:devel at edk2.groups.io
> Cc: mailto:michael.d.kinney at intel.com; mailto:sean.brogan at microsoft.com
> Subject: Re: [edk2-devel] [EXTERNAL] [PATCH v1 1/1] UnitTestFrameworkPkg: Sample unit test hangs when running in OVMF/QEMU
> 
> Reviewed-by: Bret Barkelew <mailto:bret.barkelew at microsoft.com>
> 
> - Bret
> 
> From: mailto:getnatejigu at gmail.com
> Sent: Friday, April 30, 2021 2:07 PM
> To: mailto:devel at edk2.groups.io
> Cc: mailto:michael.d.kinney at intel.com; mailto:sean.brogan at microsoft.com; mailto:Bret.Barkelew at microsoft.com
> Subject: [EXTERNAL] [PATCH v1 1/1] UnitTestFrameworkPkg: Sample unit test hangs when running in OVMF/QEMU
> 
> Sample unit tests in UnitTestFrameworkPkg hangs when running in OVMF/QEMU
> environment. Build target is X64/GCC5. Fixing this issue by adding EFIAPI
> to ReportPrint() function that use VA_ARGS.
> 
> Signed-off-by: Getnat Ejigu <mailto:getnatejigu at gmail.com>
> Cc: Michael D Kinney <mailto:michael.d.kinney at intel.com>
> Cc: Sean Brogan <mailto:sean.brogan at microsoft.com>
> Cc: Bret Barkelew <mailto:Bret.Barkelew at microsoft.com>
> ---
>  UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLib.c         | 1 +
>  UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c   | 1 +
>  UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibDebugLib.c | 1 +
>  3 files changed, 3 insertions(+)
> 
> diff --git a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLib.c
> b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLib.c
> index 66c9db457d80..7f7443a23391 100644
> --- a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLib.c
> +++ b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLib.c
> @@ -11,6 +11,7 @@
>  #include <Library/DebugLib.h>
> 
> 
> 
>  VOID
> 
> +EFIAPI
> 
>  ReportPrint (
> 
>    IN CONST CHAR8  *Format,
> 
>    ...
> 
> diff --git a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c
> b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c
> index cfb0c5972bd1..db5402d6a210 100644
> --- a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c
> +++ b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c
> @@ -12,6 +12,7 @@
>  #include <Library/DebugLib.h>
> 
> 
> 
>  VOID
> 
> +EFIAPI
> 
>  ReportPrint (
> 
>    IN CONST CHAR8  *Format,
> 
>    ...
> 
> diff --git a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibDebugLib.c
> b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibDebugLib.c
> index 1402d0ef83e2..1d62c6a37117 100644
> --- a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibDebugLib.c
> +++ b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibDebugLib.c
> @@ -11,6 +11,7 @@
>  #include <Library/DebugLib.h>
> 
> 
> 
>  VOID
> 
> +EFIAPI
> 
>  ReportPrint (
> 
>    IN CONST CHAR8  *Format,
> 
>    ...
> 
> --
> 2.25.1
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#74717): https://edk2.groups.io/g/devel/message/74717
Mute This Topic: https://groups.io/mt/82492217/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-