回复: [edk2-devel] 回复: [PATCH v1 1/1] BaseTools: build: Set ReturnCode on POSTBUILD fail

[gaoliming]

This patch is reviewed before soft feature freeze. 

So, I create PR https://github.com/tianocore/edk2/pull/1659 to merge it for
this stable tag. 

Thanks
Liming
> -----邮件原件-----
> 发件人: devel at edk2.groups.io <devel at edk2.groups.io> 代表 gaoliming
> 发送时间: 2021年5月16日 16:10
> 收件人: 'Garrett Kirkendall' <Garrett.Kirkendall at amd.com>;
> devel at edk2.groups.io
> 抄送: 'Bob Feng' <bob.c.feng at intel.com>; 'Yuwei Chen'
> <yuwei.chen at intel.com>
> 主题: [edk2-devel] 回复: [PATCH v1 1/1] BaseTools: build: Set ReturnCode
on
> POSTBUILD fail
> 
> Reviewed-by: Liming Gao <gaoliming at byosoft.com.cn>
> 
> > -----邮件原件-----
> > 发件人: Garrett Kirkendall <Garrett.Kirkendall at amd.com>
> > 发送时间: 2021年5月14日 23:02
> > 收件人: devel at edk2.groups.io
> > 抄送: Bob Feng <bob.c.feng at intel.com>; Liming Gao
> > <gaoliming at byosoft.com.cn>; Yuwei Chen <yuwei.chen at intel.com>;
> Garrett
> > Kirkendall <garrett.kirkendall at amd.com>
> > 主题: [PATCH v1 1/1] BaseTools: build: Set ReturnCode on POSTBUILD fail
> >
> > When build.by POSTBUILD handling section returns other than 0, set
> > ReturnCode to POSTBUILD_ERROR so build.py exits with return code other
> > than 0.
> >
> > Fix for https://bugzilla.tianocore.org/show_bug.cgi?id=1977
> >
> > Cc: Bob Feng <bob.c.feng at intel.com>
> > Cc: Liming Gao <gaoliming at byosoft.com.cn>
> > Cc: Yuwei Chen <yuwei.chen at intel.com>
> >
> > Signed-off-by: Garrett Kirkendall <garrett.kirkendall at amd.com>
> > ---
> >  BaseTools/Source/Python/build/build.py | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/BaseTools/Source/Python/build/build.py
> > b/BaseTools/Source/Python/build/build.py
> > index 037493f0b02a..3e4d83409f49 100755
> > --- a/BaseTools/Source/Python/build/build.py
> > +++ b/BaseTools/Source/Python/build/build.py
> > @@ -2757,6 +2757,7 @@ def Main():
> >              Conclusion = "Done"
> >
> >          except:
> >
> >              Conclusion = "Failed"
> >
> > +            ReturnCode = POSTBUILD_ERROR
> >
> >      elif ReturnCode == ABORT_ERROR:
> >
> >          Conclusion = "Aborted"
> >
> >      else:
> >
> > --
> > 2.30.1.windows.1
> 
> 
> 
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#75443): https://edk2.groups.io/g/devel/message/75443
Mute This Topic: https://groups.io/mt/82980395/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-