[edk2-devel] [PATCH 06/43] OvmfPkg/AcpiPlatformDxe: fix header file warts

Laszlo Ersek lersek at redhat.com
Wed May 26 20:14:09 UTC 2021


- Remove the leading underscores from the #include guard macro names;
  clean up the names in general.

- Remove the useless "Include/" directory prefix from the public header
  pathnames.

- Fix incorrect file-top comment.

Cc: Ard Biesheuvel <ardb+tianocore at kernel.org>
Cc: Jordan Justen <jordan.l.justen at intel.com>
Cc: Philippe Mathieu-Daudé <philmd at redhat.com>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2122
Signed-off-by: Laszlo Ersek <lersek at redhat.com>
---
 OvmfPkg/AcpiPlatformDxe/AcpiPlatform.h | 6 +++---
 OvmfPkg/AcpiPlatformDxe/QemuLoader.h   | 6 +++---
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/OvmfPkg/AcpiPlatformDxe/AcpiPlatform.h b/OvmfPkg/AcpiPlatformDxe/AcpiPlatform.h
index 9597e028e4a7..c8dee8ab7a3c 100644
--- a/OvmfPkg/AcpiPlatformDxe/AcpiPlatform.h
+++ b/OvmfPkg/AcpiPlatformDxe/AcpiPlatform.h
@@ -1,16 +1,16 @@
 /** @file
-  Sample ACPI Platform Driver
+  OVMF ACPI Platform Driver
 
   Copyright (c) 2008 - 2012, Intel Corporation. All rights reserved.<BR>
   SPDX-License-Identifier: BSD-2-Clause-Patent
 
 **/
 
-#ifndef _ACPI_PLATFORM_H_INCLUDED_
-#define _ACPI_PLATFORM_H_INCLUDED_
+#ifndef ACPI_PLATFORM_H_
+#define ACPI_PLATFORM_H_
 
 #include <PiDxe.h>
 
 #include <Protocol/AcpiTable.h>
 #include <Protocol/FirmwareVolume2.h>
 #include <Protocol/PciIo.h>
diff --git a/OvmfPkg/AcpiPlatformDxe/QemuLoader.h b/OvmfPkg/AcpiPlatformDxe/QemuLoader.h
index 70e0ebc33beb..bb3978e900ed 100644
--- a/OvmfPkg/AcpiPlatformDxe/QemuLoader.h
+++ b/OvmfPkg/AcpiPlatformDxe/QemuLoader.h
@@ -4,16 +4,16 @@
   Copyright (C) 2014, Red Hat, Inc.
 
   SPDX-License-Identifier: BSD-2-Clause-Patent
 
 **/
 
-#ifndef __QEMU_LOADER_H__
-#define __QEMU_LOADER_H__
+#ifndef QEMU_LOADER_H_
+#define QEMU_LOADER_H_
 
-#include <Include/Base.h>
+#include <Base.h>
 #include <Library/QemuFwCfgLib.h>
 
 //
 // The types and the documentation reflects the SeaBIOS interface.
 //
 #define QEMU_LOADER_FNAME_SIZE QEMU_FW_CFG_FNAME_SIZE
-- 
2.19.1.3.g30247aa5d201




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#75675): https://edk2.groups.io/g/devel/message/75675
Mute This Topic: https://groups.io/mt/83110369/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-






More information about the edk2-devel-archive mailing list