[edk2-devel] [PATCH 28/43] OvmfPkg/PciHostBridgeLib: consolidate #includes and INF file sections
Philippe Mathieu-Daudé
philmd at redhat.com
Thu May 27 08:31:01 UTC 2021
On 5/26/21 10:14 PM, Laszlo Ersek wrote:
> - In every C file, list every necessary public #include individually, with
> an example identifier that's actually consumed.
>
> - Place all public #includes first, all module-private #includes second.
> Separate them with a single empty line. Keep each section sorted in
> itself.
>
> - Sort all sections in the INF file, except [Defines].
>
> - Add unlisted lib classes.
>
> - Remove unnecessary #include directives, add unlisted #include
> directives.
>
> Cc: Anthony Perard <anthony.perard at citrix.com>
> Cc: Ard Biesheuvel <ardb+tianocore at kernel.org>
> Cc: Jordan Justen <jordan.l.justen at intel.com>
> Cc: Julien Grall <julien at xen.org>
> Cc: Philippe Mathieu-Daudé <philmd at redhat.com>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2122
> Signed-off-by: Laszlo Ersek <lersek at redhat.com>
> ---
> OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf | 7 +++---
> OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.c | 22 +++++++-----------
> OvmfPkg/Library/PciHostBridgeLib/XenSupport.c | 24 +++++++++-----------
> 3 files changed, 23 insertions(+), 30 deletions(-)
Reviewed-by: Philippe Mathieu-Daude <philmd at redhat.com>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#75770): https://edk2.groups.io/g/devel/message/75770
Mute This Topic: https://groups.io/mt/83110898/1813853
Mute #includes:https://edk2.groups.io/g/devel/mutehashtag/includes
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-
More information about the edk2-devel-archive
mailing list