[edk2-devel] [PATCH 36/43] OvmfPkg/SmbiosPlatformDxe: clean up #includes and INF

[Philippe Mathieu-Daudé]

On 5/26/21 10:14 PM, Laszlo Ersek wrote:
> - Sort all sections in the INF file.
> 
> - Remove unused packages (MdeModulePkg) and lib classes (BaseMemoryLib)
>   from the INF file.
> 
> - Restrict some lib classes (BaseLib, HobLib) and GUIDs (gEfiXenInfoGuid)
>   to IA32 and X64, in the INF file; only the IA32/X64 Xen implementation
>   requires these.
> 
> - Don't make "SmbiosPlatformDxe.h" #include everything just as a
>   convenience. Spell out directly needed #includes in every file (annotate
>   each with an example identifier consumed), drop unused #includes.
> 
> - Keep #includes sorted.
> 
> - Remove the leading underscore from the #include guard macro name in
>   "SmbiosPlatformDxe.h".
> 
> Cc: Anthony Perard <anthony.perard at citrix.com>
> Cc: Ard Biesheuvel <ardb+tianocore at kernel.org>
> Cc: Jordan Justen <jordan.l.justen at intel.com>
> Cc: Julien Grall <julien at xen.org>
> Cc: Philippe Mathieu-Daudé <philmd at redhat.com>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2122
> Signed-off-by: Laszlo Ersek <lersek at redhat.com>
> ---
>  OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.inf | 20 ++++++++++----------
>  OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.h   | 15 +++------------
>  OvmfPkg/SmbiosPlatformDxe/Qemu.c                |  8 +++++---
>  OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c   |  6 ++++++
>  OvmfPkg/SmbiosPlatformDxe/X86Xen.c              |  6 ++++--
>  5 files changed, 28 insertions(+), 27 deletions(-)

Reviewed-by: Philippe Mathieu-Daude <philmd at redhat.com>



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#75776): https://edk2.groups.io/g/devel/message/75776
Mute This Topic: https://groups.io/mt/83111084/1813853
Mute #includes:https://edk2.groups.io/g/devel/mutehashtag/includes
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-