[edk2-devel] [PATCH 19/43] OvmfPkg/OvmfXen: make "PcdPciDisableBusEnumeration" Fixed-at-Build

Philippe Mathieu-Daudé philmd at redhat.com
Thu May 27 08:42:35 UTC 2021


On 5/26/21 10:14 PM, Laszlo Ersek wrote:
> The OvmfXen platform specifies the dynamic access method for
> "PcdPciDisableBusEnumeration" needlessly.
> 
> After the DSC file sets the PCD to TRUE by default, the InitializeXen()
> function in XenPlatformPei superfluously sets the PCD to TRUE again. There
> are no other writes to the PCD in the platform.
> 
> Make the PCD Fixed-At-Build, and remove the access (in fact, the whole
> InitializeXen() function) from XenPlatformPei.
> 
> Cc: Anthony Perard <anthony.perard at citrix.com>
> Cc: Ard Biesheuvel <ardb+tianocore at kernel.org>
> Cc: Jordan Justen <jordan.l.justen at intel.com>
> Cc: Julien Grall <julien at xen.org>
> Cc: Philippe Mathieu-Daudé <philmd at redhat.com>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2122
> Signed-off-by: Laszlo Ersek <lersek at redhat.com>
> ---
>  OvmfPkg/OvmfXen.dsc                       |  2 +-
>  OvmfPkg/XenPlatformPei/XenPlatformPei.inf |  1 -
>  OvmfPkg/XenPlatformPei/Platform.h         |  5 -----
>  OvmfPkg/XenPlatformPei/Platform.c         |  1 -
>  OvmfPkg/XenPlatformPei/Xen.c              | 20 --------------------
>  5 files changed, 1 insertion(+), 28 deletions(-)

Reviewed-by: Philippe Mathieu-Daude <philmd at redhat.com>



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#75783): https://edk2.groups.io/g/devel/message/75783
Mute This Topic: https://groups.io/mt/83110677/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-





More information about the edk2-devel-archive mailing list