[edk2-devel] [PATCH 37/43] OvmfPkg/SmbiosPlatformDxe: return EFI_NOT_FOUND if there is no SMBIOS data

[Philippe Mathieu-Daudé]

On 5/26/21 10:14 PM, Laszlo Ersek wrote:
> According to the function-top comment, SmbiosTablePublishEntry() is
> supposed to return an error code if no SMBIOS data is found, from either
> GetXenSmbiosTables() or GetQemuSmbiosTables(). Currently the function
> returns EFI_SUCCESS in this case however (propagated from
> gBS->LocateProtocol()). Make the return code match the documentation.
> 
> (This issue is not too important, but it gets in the way of splitting the
> entry point function next.)
> 
> Cc: Ard Biesheuvel <ardb+tianocore at kernel.org>
> Cc: Jordan Justen <jordan.l.justen at intel.com>
> Cc: Philippe Mathieu-Daudé <philmd at redhat.com>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2122
> Signed-off-by: Laszlo Ersek <lersek at redhat.com>
> ---
>  OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Philippe Mathieu-Daude <philmd at redhat.com>



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#75785): https://edk2.groups.io/g/devel/message/75785
Mute This Topic: https://groups.io/mt/83111115/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-